Changeset 457 for trunk/LocalPlayer/Enhance.pas

Timestamp:

Nov 27, 2023, 12:10:57 AM (12 months ago)

Author:

chronos

Message:

• Modified: Use enumeration type in Help unit for better readability.
• Fixed: Corruption external help image referenced with incorrect file name case.
• Fixed: Chinese translation converted to UTF-8.
• Modified: Code cleanup.

File:

• trunk/LocalPlayer/Enhance.pas (modified) (4 diffs)

trunk/LocalPlayer/Enhance.pas

@@ -128 +128 @@
   I, stage, TerrType, TileImp, X, EndStage, Cost, LastJob: Integer;
   S: string;
-  Done: Set of jNone .. jTrans;
+  Done: set of jNone .. jTrans;
   TypeChanged: Boolean;
 begin
@@ -321 +321 @@
 procedure TEnhanceDlg.JobClick(Sender: TObject);
 var
-  stage, NewJob: Integer;
+  Stage, NewJob: Integer;
   Done: Set of jNone .. jTrans;
 
   procedure RemoveJob(J: Integer);
   begin // remove job
-    stage := 0;
-    while (stage < 5) and (MyData.EnhancementJobs[Page, stage] <> jNone) do
-    begin
-      if (MyData.EnhancementJobs[Page, stage] = J) or (J = jRoad) and
-        (MyData.EnhancementJobs[Page, stage] = jRR) or (J = jIrr) and
-        (MyData.EnhancementJobs[Page, stage] = jFarm) then
+    Stage := 0;
+    while (Stage < 5) and (MyData.EnhancementJobs[Page, Stage] <> jNone) do
+    begin
+      if (MyData.EnhancementJobs[Page, Stage] = J) or (J = jRoad) and
+        (MyData.EnhancementJobs[Page, Stage] = jRR) or (J = jIrr) and
+        (MyData.EnhancementJobs[Page, Stage] = jFarm) then
       begin
-        if stage < 4 then
-          Move(MyData.EnhancementJobs[Page, stage + 1],
-            MyData.EnhancementJobs[Page, stage], 4 - stage);
+        if Stage < 4 then
+          Move(MyData.EnhancementJobs[Page, Stage + 1],
+            MyData.EnhancementJobs[Page, Stage], 4 - Stage);
         MyData.EnhancementJobs[Page, 4] := jNone;
       end
       else
-        Inc(stage);
+        Inc(Stage);
     end;
   end;
@@ -346 +346 @@
   NewJob := TButtonC(Sender).Tag;
   Done := [];
-  stage := 0;
-  while (stage < 5) and (MyData.EnhancementJobs[Page, stage] <> jNone) do
+  Stage := 0;
+  while (Stage < 5) and (MyData.EnhancementJobs[Page, Stage] <> jNone) do
   begin
-    Include(Done, MyData.EnhancementJobs[Page, stage]);
-    Inc(stage);
+    Include(Done, MyData.EnhancementJobs[Page, Stage]);
+    Inc(Stage);
   end;
   if NewJob in Done then
@@ -362 +362 @@
     if (NewJob = jRR) and not(jRoad in Done) then
     begin
-      MyData.EnhancementJobs[Page, stage] := jRoad;
-      Inc(stage);
+      MyData.EnhancementJobs[Page, Stage] := jRoad;
+      Inc(Stage);
     end;
     if (NewJob = jFarm) and not(jIrr in Done) then
     begin
-      MyData.EnhancementJobs[Page, stage] := jIrr;
-      Inc(stage);
-    end;
-    MyData.EnhancementJobs[Page, stage] := NewJob;
+      MyData.EnhancementJobs[Page, Stage] := jIrr;
+      Inc(Stage);
+    end;
+    MyData.EnhancementJobs[Page, Stage] := NewJob;
   end;
   SmartUpdateContent;