Changeset 549 for trunk/LocalPlayer/ClientTools.pas

Timestamp:

Apr 21, 2024, 8:55:53 PM (2 weeks ago)

Author:

chronos

Message:

• Modified: Optimize code with earlier break from for cycle evaluating boolean result.
• Modified: Code cleanup.

File:

• trunk/LocalPlayer/ClientTools.pas (modified) (4 diffs)

trunk/LocalPlayer/ClientTools.pas

@@ -178 +178 @@
   Result := False;
   for p1 := 1 to nPl - 1 do
-    if G.RO[p1] <> nil then
+    if G.RO[p1] <> nil then begin
       Result := True;
+      Break;
+    end;
 end;
 
@@ -373 +375 @@
           if Abs(dx) + Abs(dy) = 2 then
             if Server(sMoveUnit - sExecute + dx and 7 shl 4 + dy and
-              7 shl 7, Me, uix, nil^) >= rExecuted then
-              Result := False;
+              7 shl 7, Me, uix, nil^) >= rExecuted then begin
+                Result := False;
+                Exit;
+              end;
 end;
 
@@ -608 +612 @@
                   dx := fix and 3 shl 1 - 3 + (dy + 3) and 1;
                   Loc1 := dLoc(MyCity[cix].Loc, dx, dy);
-                  if MarkCitiesAround(Loc1, cix) then
+                  if MarkCitiesAround(Loc1, cix) then begin
                     Done := False;
+                    Break;
+                  end;
                 end;
               Server(sSetCityTiles, Me, cix, Advice.Tiles);
@@ -664 +670 @@
         dx := fix and 3 shl 1 - 3 + (dy + 3) and 1;
         Loc1 := dLoc(MyCity[cix].Loc, dx, dy);
-        if MarkCitiesAround(Loc1, cix) then
+        if MarkCitiesAround(Loc1, cix) then begin
           Done := False;
+          Break;
+        end;
       end;
     if not Done then