Changeset 549 for trunk/AI/StdAI/AI.pas

Timestamp:

Apr 21, 2024, 8:55:53 PM (2 weeks ago)

Author:

chronos

Message:

• Modified: Optimize code with earlier break from for cycle evaluating boolean result.
• Modified: Code cleanup.

File:

• trunk/AI/StdAI/AI.pas (modified) (9 diffs)

trunk/AI/StdAI/AI.pas

@@ -1788 +1788 @@
   DistrictNeed, DistrictNeed0: array[0..maxCOD - 1] of Integer;
   ModelOrder: array[0..nMmax - 1] of Integer;
-  complete, Fortified: Boolean;
+  Complete, Fortified: Boolean;
 
   function IsBombarded(cix: Integer): Boolean;
@@ -1953 +1953 @@
             end;
 
-      complete := Loop >= FirstSurplusLoop[Cat];
+      Complete := Loop >= FirstSurplusLoop[Cat];
       for I := nModelOrder - 1 downto 0 do
       begin
@@ -1967 +1967 @@
                   Dec(DistrictNeed[District[Loc]]);
                 Destination[uix] := Loc;
-                complete := False;
+                Complete := False;
               end;
 
@@ -1980 +1980 @@
                 FindDestination(uix);
                 if Destination[uix] >= 0 then
-                  complete := False;
+                  Complete := False;
               end;
       end;
       Inc(Loop)
-    until complete;
+    until Complete;
   end;
 
@@ -2005 +2005 @@
     DistrictNeed0 := DistrictNeed;
 
-    complete := True;
+    Complete := True;
     for uix := 0 to RO.nUn - 1 do
       with MyUnit[uix] do
@@ -2015 +2015 @@
             begin
               if DistrictNeed0[District[Loc]] > 0 then
-                complete := False;
+                Complete := False;
             end
             else
@@ -2021 +2021 @@
               FindDestination(uix);
               //          if (Destination[uix]<0) and (RO.Territory[Loc]=me) then
-              //            complete:=false; // causes hangup when unit can't move due to zoc
+              //            Complete:=false; // causes hangup when unit can't move due to zoc
             end;
-  until complete;
+  until Complete;
 
   for uix := 0 to RO.nUn - 1 do
@@ -2044 +2044 @@
         case ModelCat[mix] of
           mctGroundDefender, mctGroundAttacker:
-            Dec(UnitLack[District[Loc], ModelCat[mix]])
+            Dec(UnitLack[District[Loc], ModelCat[mix]]);
         end;
 end;
@@ -2351 +2351 @@
             F := Formation[AdjacentLoc];
             if (F >= 0) and (F < maxCOD) and (OceanPresence[F] and
-              not (1 shl Me) <> 0) then
-              Result := True;
+              not (1 shl Me) <> 0) then begin
+                Result := True;
+                Exit;
+              end;
           end;
         end;