Changeset 290 for trunk/GameServer.pas

Timestamp:

Feb 26, 2021, 11:56:48 PM (4 years ago)

Author:

chronos

Message:

• Modified: Use FreeAndNil instead of Free as defensive measure.
• Modified: Use ihnerited without same method name specification.

File:

• trunk/GameServer.pas (modified) (9 diffs)

trunk/GameServer.pas

@@ -7 +7 @@
 
 uses
-  Protocol, Database, dynlibs, Platform, dateutils, fgl, LazFileUtils, Graphics;
+  Protocol, Database, dynlibs, Platform, dateutils, fgl, LazFileUtils,
+  Graphics;
 
 const
@@ -289 +290 @@
         FreeLibrary(hm);
     end;
-  PlayersBrain.Free;
-  bix.Free;
-  Brains.Free;
+  FreeAndNil(PlayersBrain);
+  FreeAndNil(bix);
+  FreeAndNil(Brains);
 end;
 
@@ -561 +562 @@
   MapFile := TFileStream.Create(GetMapsDir + DirectorySeparator + FileName,
     fmCreate or fmShareExclusive);
-  MapFile.Position := 0;
-  s := 'cEvoMap'#0;
-  MapFile.write(s[1], 8); { file id }
-  i := 0;
-  MapFile.write(i, 4); { format id }
-  MapFile.write(MaxTurn, 4);
-  MapFile.write(lx, 4);
-  MapFile.write(ly, 4);
-  MapFile.write(RealMap, MapSize * 4);
-  MapFile.Free;
+  try
+    MapFile.Position := 0;
+    s := 'cEvoMap'#0;
+    MapFile.write(s[1], 8); { file id }
+    i := 0;
+    MapFile.write(i, 4); { format id }
+    MapFile.write(MaxTurn, 4);
+    MapFile.write(lx, 4);
+    MapFile.write(ly, 4);
+    MapFile.write(RealMap, MapSize * 4);
+  finally
+    FreeAndNil(MapFile);
+  end;
 end;
 
@@ -613 +617 @@
       result := true;
     end;
-    MapFile.Free;
+    FreeAndNil(MapFile);
   except
     if MapFile <> nil then
-      MapFile.Free;
+      FreeAndNil(MapFile);
   end;
 end;
@@ -694 +698 @@
   else
     CL.SaveToFile(LogFile);
-  LogFile.Free;
+  FreeAndNil(LogFile);
   if auto then
   begin
@@ -721 +725 @@
         Brains.GetByKind(btAI, AIBrains);
         bix[p1] := AIBrains[DelphiRandom(AIBrains.Count)];
-        AIBrains.Free;
+        FreeAndNil(AIBrains);
       end
     else
@@ -992 +996 @@
   CityProcessing.ReleaseGame;
   Database.ReleaseGame;
-  CL.Free;
+  FreeAndNil(CL);
 end;
 
@@ -1190 +1194 @@
     CL.LoadFromFile(LogFile);
   end;
-  LogFile.Free;
+  FreeAndNil(LogFile);
   if not result then
     Exit;
@@ -4604 +4608 @@
 begin
   FreeAndNil(Picture);
-  inherited Destroy;
+  inherited;
 end;