Changeset 143 for trunk/Start.pas

Timestamp:

May 8, 2018, 4:37:34 PM (6 years ago)

Author:

chronos

Message:

• Modified: Brains array changed to object list and TBrainInfo record to TBrain class for better code maintainability.

File:

• trunk/Start.pas (modified) (28 diffs)

trunk/Start.pas

@@ -70 +70 @@
     procedure ReplayBtnClick(Sender: TObject);
   public
-    BrainPicture: array [0 .. maxBrain - 1] of TBitmap;
     EmptyPicture: TBitmap;
     procedure UpdateFormerGames;
     procedure UpdateMaps;
   private
-    WorldSize, StartLandMass, MaxTurn, AutoEnemies, AutoDiff, MultiControl,
-      MiniWidth, MiniHeight, SelectedAction, Page, ShowTab, Tab, Diff0,
-      bixDefault, nMapLandTiles, nMapStartPositions, LoadTurn, LastTurn,
+    WorldSize: Integer;
+    StartLandMass: Integer;
+    MaxTurn: Integer;
+    AutoEnemies: Integer;
+    AutoDiff: Integer;
+    MultiControl: Integer;
+    MiniWidth: Integer;
+    MiniHeight: Integer;
+    SelectedAction: Integer;
+    Page: Integer;
+    ShowTab: Integer;
+    Tab: Integer;
+    Diff0: Integer;
+    bixDefault: Integer;
+    nMapLandTiles: Integer;
+    nMapStartPositions: Integer;
+    LoadTurn: Integer;
+    LastTurn: Integer;
     { last turn of selected former game }
-    SlotAvailable, bixPopup: integer; { brain concerned by brain context menu }
+    SlotAvailable: Integer;
+    bixPopup: Integer; { brain concerned by brain context menu }
     ListIndex: array [0 .. 3] of integer;
     MapFileName: string;
@@ -186 +201 @@
   r0, r1: HRgn;
   Location: TPoint;
+  AIBrains: TBrains;
 begin
   LoadConfig;
@@ -195 +211 @@
 
   bixDefault := -1;
-  for i := bixRandom to nBrain - 1 do
-    if AnsiCompareFileName(DefaultAI, Brain[i].FileName) = 0 then
+  for i := Brains.IndexOf(BrainRandom) to Brains.Count - 1 do
+    if AnsiCompareFileName(DefaultAI, Brains[i].FileName) = 0 then
       bixDefault := i;
-  if (bixDefault = bixRandom) and (nBrain < bixFirstAI + 2) then
+  if (bixDefault = Brains.IndexOf(BrainRandom)) and (Brains.GetKindCount(btAI) < 2) then
     bixDefault := -1;
-  if (bixDefault < 0) and (nBrain > bixFirstAI) then
-    bixDefault := bixFirstAI; // default AI not found, use any
+  if (bixDefault < 0) and (Brains.GetKindCount(btAI) > 0) then
+    begin
+      AIBrains := TBrains.Create(False);
+      Brains.GetByKind(btAI, AIBrains);
+      bixDefault := Brains.IndexOf(Brains[0]);
+      AIBrains.Free;
+    end; // default AI not found, use any
 
   DirectDlg.Left := (Screen.Width - DirectDlg.Width) div 2;
@@ -269 +290 @@
     CustomizeBtn.ButtonIndex := 2;
 
-  BrainPicture[0] := TBitmap.Create;
-  BrainPicture[0].SetSize(64, 64);
-  BitBlt(BrainPicture[0].Canvas.Handle, 0, 0, 64, 64,
+  Brains[0].Picture := TBitmap.Create;
+  Brains[0].Picture.SetSize(64, 64);
+  BitBlt(Brains[0].Picture.Canvas.Handle, 0, 0, 64, 64,
     GrExt[HGrSystem2].Data.Canvas.Handle, 1, 111, SRCCOPY);
-  BrainPicture[1] := TBitmap.Create;
-  BrainPicture[1].SetSize(64, 64);
-  BitBlt(BrainPicture[1].Canvas.Handle, 0, 0, 64, 64,
+  Brains[1].Picture := TBitmap.Create;
+  Brains[1].Picture.SetSize(64, 64);
+  BitBlt(Brains[1].Picture.Canvas.Handle, 0, 0, 64, 64,
     GrExt[HGrSystem2].Data.Canvas.Handle, 66, 111, SRCCOPY);
-  BrainPicture[2] := TBitmap.Create;
-  BrainPicture[2].SetSize(64, 64);
-  BitBlt(BrainPicture[2].Canvas.Handle, 0, 0, 64, 64,
+  Brains[2].Picture := TBitmap.Create;
+  Brains[2].Picture.SetSize(64, 64);
+  BitBlt(Brains[2].Picture.Canvas.Handle, 0, 0, 64, 64,
     GrExt[HGrSystem2].Data.Canvas.Handle, 131, 111, SRCCOPY);
-  BrainPicture[3] := TBitmap.Create;
-  BrainPicture[3].SetSize(64, 64);
-  BitBlt(BrainPicture[3].Canvas.Handle, 0, 0, 64, 64,
+  Brains[3].Picture := TBitmap.Create;
+  Brains[3].Picture.SetSize(64, 64);
+  BitBlt(Brains[3].Picture.Canvas.Handle, 0, 0, 64, 64,
     GrExt[HGrSystem2].Data.Canvas.Handle, 131, 46, SRCCOPY);
-  for i := bixFirstAI to nBrain - 1 do begin
-    BrainPicture[i] := TBitmap.Create;
-    if not LoadGraphicFile(BrainPicture[i], HomeDir + 'AI' + DirectorySeparator +
-      Brain[i].FileName + DirectorySeparator + Brain[i].FileName + '.png',
-      gfNoError) then begin
-      BrainPicture[i].SetSize(64, 64);
-      with BrainPicture[i].Canvas do begin
+
+  AIBrains := TBrains.Create(False);
+  Brains.GetByKind(btAI, AIBrains);
+  for i := 0 to AIBrains.Count - 1 do
+  with AIBrains[I] do
+  begin
+    AIBrains[i].Picture := TBitmap.Create;
+    if not LoadGraphicFile(AIBrains[i].Picture, HomeDir + 'AI' + DirectorySeparator +
+      FileName + DirectorySeparator + FileName + '.png', gfNoError) then begin
+      AIBrains[i].Picture.SetSize(64, 64);
+      with AIBrains[i].Picture.Canvas do begin
         Brush.Color := $904830;
         FillRect(Rect(0, 0, 64, 64));
@@ -297 +322 @@
         Font.Style := [];
         Font.Color := $5FDBFF;
-        Textout(32 - TextWidth(Brain[i].FileName) div 2,
-          32 - TextHeight(Brain[i].FileName) div 2, Brain[i].FileName);
+        Textout(32 - TextWidth(FileName) div 2,
+          32 - TextHeight(FileName) div 2, FileName);
       end;
     end;
   end;
+  AIBrains.Free;
 
   EmptyPicture := TBitmap.Create;
@@ -318 +344 @@
   InitButtons;
 
-  bixView[0] := bixTerm;
+  bixView[0] := Brains.IndexOf(BrainTerm);
   SlotAvailable := -1;
   Tab := 2;
@@ -333 +359 @@
 
 procedure TStartDlg.FormDestroy(Sender: TObject);
-var
-  i: integer;
 begin
   FreeAndNil(FormerGames);
@@ -341 +365 @@
   FreeAndNil(EmptyPicture);
   FreeAndNil(LogoBuffer);
-  for i := 0 to nBrain - 1 do
-    FreeAndNil(BrainPicture[i]);
 end;
 
@@ -624 +646 @@
         begin
           if bixView[i] >= 0 then
-            FrameImage(Canvas, BrainPicture[bixView[i]], xBrain[i], yBrain[i],
+            FrameImage(Canvas, Brains[bixView[i]].Picture, xBrain[i], yBrain[i],
               64, 64, 0, 0, true)
           else
             FrameImage(Canvas, EmptyPicture, xBrain[i], yBrain[i], 64, 64,
               0, 0, true);
-          if bixView[i] >= bixTerm then
+          if Brains[bixView[i]].Kind in [btTerm, btRandom, btAI] then
           begin
             BitBlt(Canvas.Handle, xBrain[i] - 18, yBrain[i] + 19, 12, 14,
@@ -658 +680 @@
           begin
             DiffUpBtn[i].Hint := Format(Phrases.Lookup('STARTCONTROLS', 9),
-              [Brain[bixView[i]].Name]);
+              [Brains[bixView[i]].Name]);
             DiffDownBtn[i].Hint := DiffUpBtn[i].Hint;
           end
@@ -681 +703 @@
         yMain + 164 { y0Mini-77 } , Phrases.Lookup('STARTCONTROLS', 16));
       if AutoDiff = 1 then
-        FrameImage(Canvas, BrainPicture[bixBeginner], xDefault, yDefault, 64,
+        FrameImage(Canvas, BrainBeginner.Picture, xDefault, yDefault, 64,
           64, 0, 0, false)
       else
-        FrameImage(Canvas, BrainPicture[bixDefault], xDefault, yDefault, 64, 64,
+        FrameImage(Canvas, Brains[bixDefault].Picture, xDefault, yDefault, 64, 64,
           0, 0, true);
       DLine(Canvas, 56, 272, y0Mini + 61 + 19, MainTexture.clBevelLight,
@@ -895 +917 @@
             else GameCount := 0;
 
-          if (AutoDiff < 0) and (bixView[0] = bixNoTerm) then
+          if (AutoDiff < 0) and (Brains[bixView[0]].Kind = btNoTerm) then
             FileName := 'Round' + IntToStr(GetProcessID())
           else begin
@@ -913 +935 @@
                   Reg.WriteString('Control' + IntToStr(i), '')
                 else Reg.WriteString('Control' + IntToStr(i),
-                  Brain[bixView[i]].FileName);
+                  Brains[bixView[i]].FileName);
                 WriteInteger('Diff' + IntToStr(i), Difficulty[i]);
               end;
@@ -922 +944 @@
           if AutoDiff > 0 then
           begin
-            WriteString('DefaultAI', Brain[bixDefault].FileName);
+            WriteString('DefaultAI', Brains[bixDefault].FileName);
             SlotAvailable := 0; // bixView will be invalid hereafter
-            bixView[0] := bixTerm;
+            bixView[0] := Brains.IndexOf(BrainTerm);
             Difficulty[0] := PlayerAutoDiff[AutoDiff];
             for i := 1 to nPl - 1 do
               if (Page = pgStartRandom) and (i <= AutoEnemies) or
                 (Page = pgStartMap) and (i < nMapStartPositions) then begin
-                if AutoDiff = 1 then bixView[i] := bixBeginner
+                if AutoDiff = 1 then bixView[i] := Brains.IndexOf(BrainBeginner)
                   else bixView[i] := bixDefault;
                 Difficulty[i] := EnemyAutoDiff[AutoDiff];
@@ -935 +957 @@
           end else begin
             for i := 6 to 8 do
-              if (bixView[0] <> bixNoTerm) and (MultiControl and (1 shl i) <> 0)
+              if (Brains[bixView[0]].Kind <> btNoTerm) and (MultiControl and (1 shl i) <> 0)
               then begin
                 bixView[i + 3] := bixView[i];
@@ -1218 +1240 @@
   else
   begin
-    Brain[bixView[bixPopup]].Flags := Brain[bixView[bixPopup]].Flags and
+    Brains[bixView[bixPopup]].Flags := Brains[bixView[bixPopup]].Flags and
       not fUsed;
     bixView[bixPopup] := TMenuItem(Sender).Tag;
-    DiffUpBtn[bixPopup].Visible := bixView[bixPopup] >= bixTerm;
-    DiffDownBtn[bixPopup].Visible := bixView[bixPopup] >= bixTerm;
+    DiffUpBtn[bixPopup].Visible := Brains[bixView[bixPopup]].Kind in [btTerm, btRandom, btAI];
+    DiffDownBtn[bixPopup].Visible := Brains[bixView[bixPopup]].Kind in [btTerm, btRandom, btAI];
     if bixPopup in OfferMultiple then
     begin
-      MultiBtn[bixPopup].Visible := bixView[bixPopup] >= bixTerm;
+      MultiBtn[bixPopup].Visible := Brains[bixView[bixPopup]].Kind in [btTerm, btRandom, btAI];
       MultiBtn[bixPopup].ButtonIndex := 2 + (MultiControl shr bixPopup) and 1;
     end;
-    Brain[bixView[bixPopup]].Flags := Brain[bixView[bixPopup]].Flags or fUsed;
-    if bixView[bixPopup] < bixTerm then
+    Brains[bixView[bixPopup]].Flags := Brains[bixView[bixPopup]].Flags or fUsed;
+    if Brains[bixView[bixPopup]].Kind in [btNoTerm, btSuperVirtual] then
       Difficulty[bixPopup] := 0 { supervisor }
     else
@@ -1238 +1260 @@
     if (bixPopup = 0) and (MapFileName <> '') then
       ChangePage(Page);
-    if bixView[bixPopup] = bixNoTerm then
+    if Brains[bixView[bixPopup]].Kind = btNoTerm then
     begin // turn all local players off
       for i := 1 to nPlOffered - 1 do
-        if bixView[i] = bixTerm then
+        if Brains[bixView[i]].Kind = btTerm then
         begin
           bixView[i] := -1;
@@ -1256 +1278 @@
             DiffUpBtn[i].top + 25);
         end;
-      Brain[bixTerm].Flags := Brain[bixTerm].Flags and not fUsed;
+      BrainTerm.Flags := BrainTerm.Flags and not fUsed;
     end;
     SmartInvalidate(xBrain[bixPopup] - 31, yBrain[bixPopup] - 1,
@@ -1267 +1289 @@
   i, FixedLines: integer;
   m: TMenuItem;
+  AIBrains: TBrains;
 
   procedure OfferBrain(Index: integer);
@@ -1276 +1299 @@
       m.Caption := Phrases.Lookup('NOMOD')
     else
-      m.Caption := Brain[Index].Name;
+      m.Caption := Brains[Index].Name;
     m.Tag := Index;
     m.OnClick := BrainClick;
@@ -1297 +1320 @@
   begin // select default AI
     FixedLines := 0;
-    if nBrain >= bixFirstAI + 2 then
+    if Brains.GetKindCount(btAI) >= 2 then
     begin
-      OfferBrain(bixRandom);
+      OfferBrain(Brains.IndexOf(BrainRandom));
       inc(FixedLines)
     end;
-    for i := bixFirstAI to nBrain - 1 do // offer available AIs
-      if Brain[i].Flags and fMultiple <> 0 then
-        OfferBrain(i);
+    AIBrains := TBrains.Create(False);
+    Brains.GetByKind(btAI, AIBrains);
+    for i := 0 to AIBrains.Count - 1 do // offer available AIs
+      if AIBrains[i].Flags and fMultiple <> 0 then
+        OfferBrain(Brains.IndexOf(AIBrains[i]));
+    AIBrains.Free;
   end
   else
@@ -1314 +1340 @@
       inc(FixedLines);
     end;
-    for i := bixTerm downto 0 do // offer game interfaces
-      if (bixPopup = 0) or (i = bixTerm) and (bixView[0] <> bixNoTerm) then
+    for i := Brains.IndexOf(BrainTerm) downto 0 do // offer game interfaces
+      if (bixPopup = 0) or (Brains[i].Kind = btTerm) and (Brains[bixView[0]].Kind <> btNoTerm) then
       begin
         OfferBrain(i);
@@ -1326 +1352 @@
       PopupMenu1.Items.Add(m);
       inc(FixedLines);
-      if nBrain >= bixFirstAI + 2 then
-      begin
-        OfferBrain(bixRandom);
+      if Brains.GetKindCount(btAI) >= 2 then
+      begin
+        OfferBrain(Brains.IndexOf(BrainRandom));
         inc(FixedLines);
       end;
-      for i := bixFirstAI to nBrain - 1 do // offer available AIs
-        if (Brain[i].Flags and fMultiple <> 0) or (Brain[i].Flags and fUsed = 0)
+      AIBrains := TBrains.Create(False);
+      Brains.GetByKind(btAI, AIBrains);
+      for i := 0 to AIBrains.Count - 1 do // offer available AIs
+        if (AIBrains[i].Flags and fMultiple <> 0) or (AIBrains[i].Flags and fUsed = 0)
           or (i = bixView[bixPopup]) then
-          OfferBrain(i);
+          OfferBrain(Brains.IndexOf(AIBrains[i]));
+      AIBrains.Free;
     end;
   end
@@ -1397 +1426 @@
           if i = 0 then
           begin
-            bixView[0] := bixSuper_Virtual;
+            bixView[0] := Brains.IndexOf(BrainSuperVirtual);
             Difficulty[0] := 0
           end;
-          if bixView[0] < bixTerm then
+          if Brains[bixView[0]].Kind in [btNoTerm, btSuperVirtual] then
             inc(i);
           if i > nPl then
@@ -1421 +1450 @@
                 Difficulty[p1] := ReadInteger('Diff' + IntToStr(p1));
                 if s <> '' then
-                  for j := 0 to nBrain - 1 do
-                    if AnsiCompareFileName(s, Brain[j].FileName) = 0 then
+                  for j := 0 to Brains.Count - 1 do
+                    if AnsiCompareFileName(s, Brains[j].FileName) = 0 then
                       bixView[p1] := j;
               end;
@@ -1441 +1470 @@
         SlotAvailable := InitAlive[i];
         for i := 0 to nPlOffered - 1 do
-          if (AutoDiff < 0) and (bixView[i] >= bixTerm) then
+          if (AutoDiff < 0) and (Brains[bixView[i]].Kind in [btTerm, btRandom, btAI]) then
           begin
             DiffUpBtn[i].Tag := 768;
@@ -1452 +1481 @@
           end;
         for i := 6 to 8 do
-          if (AutoDiff < 0) and (bixView[i] >= bixTerm) then
+          if (AutoDiff < 0) and (Brains[bixView[i]].Kind in [btTerm, btRandom, btAI]) then
           begin
             MultiBtn[i].Tag := 768;
@@ -1593 +1622 @@
     (x >= xDefault) and (y >= yDefault) and (x < xDefault + 64) and
     (y < yDefault + 64) then
-    if nBrain < bixFirstAI + 2 then
+    if Brains.GetKindCount(btAI) < 2 then
       SimpleMessage(Phrases.Lookup('NOALTAI'))
     else