Changeset 401 for tags/1.4.0/Units.pas

Timestamp:

Jan 6, 2025, 11:12:12 AM (3 days ago)

Author:

chronos

Message:

Merged revision(s) 396-400 from trunk:

• Fixed: Charts form chart was not drawn on the initial show.
• Fixed: Run Randomize only once at startup.
• Fixed: Store current state of RandSeed to game save.
• Fixed: Load/store RandSeed as its Cardinal type instead of Integer.
• Modified: Maximum number of player set to 12.
• Fixed: Standard yellow color is too bright and not readable with white text. Used darker yellow instead.
• Fixed: Integrity checks for id references loaded from game file.
• Fixed: Wrong players and units id recalculation during game save causing bad references.
• Modified: Set new created players as computer.
• Fixed: Scale charts line width.
• Fixed: Item form made bigger to avoid showing scrollbars.
• Fixed: Item form string control made shorter.

Location:

tags/1.4.0

Files:

• . (modified) (1 prop)
• Units.pas (modified) (2 diffs)

tags/1.4.0/Units.pas

@@ -114 +114 @@
   NewNode2: TDOMNode;
 begin
-  RecalculateItemsId;
   for I := 0 to Count - 1 do
   with Items[I] do begin
@@ -188 +187 @@
 procedure TUnit.FixRefId;
 begin
-  Player := TGame(Game).Players.FindById(PlayerId);
-  Kind := TGame(Game).GameSystem.UnitKinds.FindById(KindId);
+  if PlayerId <> 0 then begin
+    Player := TGame(Game).Players.FindById(PlayerId);
+    if not Assigned(Player) then
+      raise Exception.Create('Referenced player id ' + IntToStr(PlayerId) + ' not found.');
+  end else Player := nil;
+
+  if KindId <> 0 then begin
+    Kind := TGame(Game).GameSystem.UnitKinds.FindById(KindId);
+    if not Assigned(Kind) then
+      raise Exception.Create('Referenced unit kind id ' + IntToStr(KindId) + ' not found.');
+  end else Kind := nil;
 end;