Changeset 901 for trunk/Modules/ClientVersion/ClientVersion.php

Timestamp:

Oct 2, 2024, 10:31:47 PM (2 days ago)

Author:

chronos

Message:

• Fixed: More integer URL parameters checking.
• Modified: More explicit function types.

File:

• trunk/Modules/ClientVersion/ClientVersion.php (modified) (1 diff)

trunk/Modules/ClientVersion/ClientVersion.php

@@ -39 +39 @@
   }
 
-  function ShowItem()
+  function ShowItem(): string
   {
-    if (array_key_exists('id', $_GET))
+    $Id = 0;
+    if (TryGetUrlParameterInt('id', $Id))
     {
       $YesNo = array('Ne', 'Ano');
-      $DbResult = $this->System->Database->query('SELECT * FROM `ClientVersion` WHERE `Id`='.($_GET['id']*1));
+      $DbResult = $this->System->Database->query('SELECT * FROM `ClientVersion` WHERE `Id`='.$Id);
       if ($DbResult->num_rows > 0)
       {
         $Version = $DbResult->fetch_assoc();
 
-      $Output = '<h3>'.T('Client version').'</h3>';
-      $Output .= '<table class="BaseTable">'.
-        '<tr><td>'.T('Version').'</td><td>'.$Version['Version'].'</td></tr>'.
-        '<tr><td>'.T('More information').'</td><td><a href="http://www.wowwiki.com/Patch_'.$Version['Version'].'">wowwiki.com'.
-        '</a></td></tr>'.
-        '<tr><td>'.T('Build number').'</td><td>'.$Version['BuildNumber'].'</td></tr>'.
-        '<tr><td>'.T('Release date').'</td><td>'.HumanDate($Version['ReleaseDate']).'</td></tr>'.
-        '<tr><td>'.T('Title').'</td><td>'.$Version['Title'].'</td></tr>'.
-        '<tr><td>'.T('Imported').'</td><td>'.$YesNo[$Version['Imported']].'</td></tr>'.
-        '</table>';
+        $Output = '<h3>'.T('Client version').'</h3>';
+        $Output .= '<table class="BaseTable">'.
+          '<tr><td>'.T('Version').'</td><td>'.$Version['Version'].'</td></tr>'.
+          '<tr><td>'.T('More information').'</td><td><a href="http://www.wowwiki.com/Patch_'.$Version['Version'].'">wowwiki.com'.
+          '</a></td></tr>'.
+          '<tr><td>'.T('Build number').'</td><td>'.$Version['BuildNumber'].'</td></tr>'.
+          '<tr><td>'.T('Release date').'</td><td>'.HumanDate($Version['ReleaseDate']).'</td></tr>'.
+          '<tr><td>'.T('Title').'</td><td>'.$Version['Title'].'</td></tr>'.
+          '<tr><td>'.T('Imported').'</td><td>'.$YesNo[$Version['Imported']].'</td></tr>'.
+          '</table>';
         $Output .= '<div><a href="?">'.T('All versions list').'</a></div>';
         if ($Version['Imported'])
+        {
           $Output .= '<div><a href="'.$this->System->Link('/progress/?Version='.
             $Version['Version']).'">'.T('Progress').'</a></div>';
+        }
       } else $Output = ShowMessage(T('Item not found'), MESSAGE_CRITICAL);
-    } else $Output = ShowMessage(T('Item not found'), MESSAGE_CRITICAL);
+    } else $Output = ShowMessage(T('Id not valid'), MESSAGE_CRITICAL);
     return $Output;
   }
 
-  function ShowList()
+  function ShowList(): string
   {
     $this->Title = T('Game version');