Changeset 851 for trunk/Modules/User/Registration.php

Timestamp:

Jan 17, 2016, 10:07:13 PM (8 years ago)

Author:

chronos

Message:

• Fixed: Use htmlspecialchars function for user inserted content to avoid breaking page HTML structure. Added for forum, teams, dictionary and profile text.

File:

• trunk/Modules/User/Registration.php (modified) (3 diffs)

trunk/Modules/User/Registration.php

@@ -19 +19 @@
     <fieldset><legend>'.T('New user registration').'</legend>
     <table>
-    <tr><td colspan="2">'.T('Please read carefully <a href="'.$this->System->Link('/info/').'">translation guidelines</a> and follow them. Translate with diacritics!').'<br/><br/></td></tr>
+    <tr><td colspan="2">'.sprintf(T('Please read carefully %s and follow them. Translate with diacritics!'),
+      '<a href="'.$this->System->Link('/info/').'">'.T('translation guidelines').'</a>').
+      '<br/><br/></td></tr>
     <tr>
     <th class="Left">'.T('Are you human?').'</th>';
@@ -27 +29 @@
     </tr>
     <tr>
-    <th class="Left">'.T('Name:').'</th>
+    <th class="Left">'.T('Name').':</th>
     <td><input type="text" name="user" value="'.$UserName.'"/></td>
     </tr>
     <tr>
-    <th class="Left">'.T('Password:').'</th>
+    <th class="Left">'.T('Password').':</th>
     <td><input type="password" name="pass" /></td>
     </tr>
     <tr>
-    <th class="Left">'.T('Password confirmation:').'</th>
+    <th class="Left">'.T('Password confirmation').':</th>
     <td><input type="password" name="pass2" /></td>
     </tr>
     <tr>
-    <th class="Left">'.T('E-mail:').'</th>
+    <th class="Left">'.T('E-mail').':</th>
     <td><input type="text" name="Email" value="'.$Email.'"/></td>
     </tr>
     <tr>
-    <th class="Left">'.T('I will translate normally to:').'</th>
+    <th class="Left">'.T('I will translate normally to').':</th>
     <td>'.WriteLanguages($Language).'</td>
     </tr>
     <tr>
-    <th class="Left">'.T('I belong to team:').'</th>';
+    <th class="Left">'.T('I belong to team').':</th>';
     if($Team == '') $Selected = ' selected="selected"';
       else $Selected = '';
@@ -56 +58 @@
       if($Team == $Line['Id']) $Selected = ' selected="selected"';
       else $Selected = '';
-      $Output .= '<option value="0'.$Line['Id'].'"'.$Selected.'>'.$Line['Name'].'</option>';
+      $Output .= '<option value="0'.$Line['Id'].'"'.$Selected.'>'.htmlspecialchars($Line['Name']).'</option>';
     }
     $Output .= '</select>';
     $Output .= '</td></tr>'.
-      '<tr><th class="Left">'.T('Preferred client version:').'</th><td>'.ClientVersionSelection('').'</td></tr>';
+      '<tr><th class="Left">'.T('Preferred client version').':</th><td>'.ClientVersionSelection('').'</td></tr>';
 
     $Query = 'SELECT * FROM UserTagType';
     $DbResult = $this->Database->query($Query);
     $Output .= '<tr><th class="Left">'.
-      T('Select rules which you will apply during translation:').'</th><td>';
+      T('Select rules which you will apply during translation').':</th><td>';
     while ($UserTag = $DbResult->fetch_array())
     {