Changeset 52 for trunk/Forms/UFormContacts.pas

Timestamp:

Dec 3, 2021, 8:50:43 PM (3 years ago)

Author:

chronos

Message:

• Fixed: Wrong object reference to contact Parent after Merge files action.
• Modified: Optimized select all action.

File:

• trunk/Forms/UFormContacts.pas (modified) (8 diffs)

trunk/Forms/UFormContacts.pas

@@ -53 +53 @@
   private
     FContacts: TContacts;
+    FUpdateCount: Integer;
     procedure FilterList(List: TFPGObjectList<TObject>);
     procedure SetContacts(AValue: TContacts);
     procedure FormContactPrevious(Sender: TObject);
     procedure FormContactNext(Sender: TObject);
+    procedure DoUpdateInterface;
   public
     property Contacts: TContacts read FContacts write SetContacts;
     procedure ReloadList;
+    procedure BeginUpdate;
+    procedure EndUpdate;
     procedure UpdateInterface;
   end;
@@ -80 +84 @@
   SFiltered = 'Filtered';
   SSelected = 'Selected';
+  SEndUpdateTooLow = 'Update counter error';
 
 { TFormContacts }
@@ -99 +104 @@
   if Item.Index < ListViewSort1.List.Count then
   with TContact(ListViewSort1.List[Item.Index]) do begin
-
     AddItem(Fields[cfFullName], True);
     AddItem(Fields[cfFirstName]);
@@ -220 +224 @@
 end;
 
+procedure TFormContacts.DoUpdateInterface;
+var
+  Text: string;
+  SelectedCount: Integer;
+begin
+  AAdd.Enabled := Assigned(Contacts);
+  AModify.Enabled := Assigned(Contacts) and Assigned(ListView1.Selected);
+  ARemove.Enabled := Assigned(Contacts) and Assigned(ListView1.Selected);
+
+  Text := '';
+  if Assigned(Contacts) then begin
+    Text := STotal + ': ' + IntToStr(Contacts.Count);
+    if ListView1.Items.Count < Contacts.Count then
+      Text := Text + ', ' + SFiltered + ': ' + IntToStr(ListView1.Items.Count);
+    SelectedCount := ListView1.SelCount;
+    if SelectedCount > 0 then
+      Text := Text + ', ' + SSelected + ': ' + IntToStr(SelectedCount);
+  end;
+  StatusBar1.Panels[0].Text := Text;
+end;
+
 procedure TFormContacts.FormShow(Sender: TObject);
 begin
@@ -268 +293 @@
     Contact := TContact.Create;
     try
+      Contact.Parent := Contacts.ContactsFile;
       Contact.Assign(TContact(ListView1.Selected.Data));
       FormContact.Contact := Contact;
@@ -297 +323 @@
     Contact := TContact.Create;
     try
+      Contact.Parent := Contacts.ContactsFile;
       Contact.Assign(TContact(ListView1.Selected.Data));
       FormContact.Contact := Contact;
@@ -333 +360 @@
 
 procedure TFormContacts.ASelectAllExecute(Sender: TObject);
-begin
-  ListView1.SelectAll;
-  UpdateInterface;
+var
+  I: Integer;
+begin
+  BeginUpdate;
+  ListView1.BeginUpdate;
+  for I := 0 to ListView1.Items.Count - 1 do
+    ListView1.Items[I].Selected := True;
+  //ListView1.SelectAll;
+  ListView1.EndUpdate;
+  EndUpdate;
 end;
 
@@ -360 +394 @@
 end;
 
+procedure TFormContacts.BeginUpdate;
+begin
+  Inc(FUpdateCount);
+end;
+
+procedure TFormContacts.EndUpdate;
+begin
+  if FUpdateCount <= 0 then raise Exception(SEndUpdateTooLow);
+  Dec(FUpdateCount);
+  if FUpdateCount = 0 then DoUpdateInterface;
+end;
+
 procedure TFormContacts.UpdateInterface;
-var
-  Text: string;
-  SelectedCount: Integer;
-begin
-  AAdd.Enabled := Assigned(Contacts);
-  AModify.Enabled := Assigned(Contacts) and Assigned(ListView1.Selected);
-  ARemove.Enabled := Assigned(Contacts) and Assigned(ListView1.Selected);
-
-  Text := '';
-  if Assigned(Contacts) then begin
-    Text := STotal + ': ' + IntToStr(Contacts.Count);
-    if ListView1.Items.Count < Contacts.Count then
-      Text := Text + ', ' + SFiltered + ': ' + IntToStr(ListView1.Items.Count);
-    SelectedCount := ListView1.SelCount;
-    if SelectedCount > 0 then
-      Text := Text + ', ' + SSelected + ': ' + IntToStr(SelectedCount);
-  end;
-  StatusBar1.Panels[0].Text := Text;
+begin
+  if FUpdateCount = 0 then DoUpdateInterface;
 end;