Changeset 887 for trunk/Modules/Stock/Stock.php

Timestamp:

Nov 20, 2020, 12:08:12 AM (4 years ago)

Author:

chronos

Message:

• Added: Static types added to almost all classes, methods and function. Supported by PHP 7.4.
• Fixed: Various found code issues.

File:

• trunk/Modules/Stock/Stock.php (modified) (3 diffs)

trunk/Modules/Stock/Stock.php

@@ -3 +3 @@
 class ModuleStock extends AppModule
 {
-  function __construct($System)
+  function __construct(System $System)
   {
     parent::__construct($System);
@@ -14 +14 @@
   }
 
-  function DoStart()
+  function DoStart(): void
   {
     global $Config;
@@ -246 +246 @@
   }
 
-  function BeforeInsertStockMove($Form)
+  function BeforeInsertStockMove(Form $Form): array
   {
+    $Finance = &ModuleFinance::Cast($this->System->GetModule('Finance'))->Finance;
     if (array_key_exists('Time', $Form->Values)) $Year = date("Y", $Form->Values['Time']);
       else $Year = date("Y", $Form->Values['ValidFrom']);
-    $Group = $this->System->Modules['Finance']->GetFinanceGroupById($Form->Values['Group'], 'StockMoveGroup');
-    $Form->Values['BillCode'] = $this->System->Modules['Finance']->GetNextDocumentLineNumberId($Group['DocumentLine'], $Year);
+    $Group = $Finance->GetFinanceGroupById($Form->Values['Group'], 'StockMoveGroup');
+    $Form->Values['BillCode'] = $Finance->GetNextDocumentLineNumberId($Group['DocumentLine'], $Year);
     return $Form->Values;
   }