Changeset 887 for trunk/Modules/Scheduler/Scheduler.php

Timestamp:

Nov 20, 2020, 12:08:12 AM (3 years ago)

Author:

chronos

Message:

• Added: Static types added to almost all classes, methods and function. Supported by PHP 7.4.
• Fixed: Various found code issues.

File:

• trunk/Modules/Scheduler/Scheduler.php (modified) (4 diffs)

trunk/Modules/Scheduler/Scheduler.php

@@ -3 +3 @@
 class ModuleScheduler extends AppModule
 {
-  function __construct($System)
+  function __construct(System $System)
   {
     parent::__construct($System);
@@ -14 +14 @@
   }
 
-  function DoStart()
+  function DoStart(): void
   {
     $this->System->FormManager->RegisterClass('Scheduler', array(
@@ -48 +48 @@
       'Filter' => '1',
     ));
-    $this->System->RegisterCommandLine('run-scheduler', array($this->System->ModuleManager->Modules['Scheduler'], 'Run'));
+    $this->System->RegisterCommandLine('run-scheduler', 'Runs scheduled tasks',
+      array(ModuleScheduler::Cast($this->System->GetModule('Scheduler')), 'Run'));
   }
 
-  function DoInstall()
+  function DoInstall(): void
   {
   }
 
-  function DoUnInstall()
+  function DoUnInstall(): void
   {
   }
 
-  function Run($Parameters)
+  function Run(array $Parameters): void
   {
     while (true)
@@ -100 +101 @@
     }
   }
+
+  static function Cast(AppModule $AppModule): ModuleScheduler
+  {
+    if ($AppModule instanceof ModuleScheduler)
+    {
+      return $AppModule;
+    }
+    throw new Exception('Expected ModuleScheduler type but got '.gettype($AppModule));
+  }
 }
 
 class SchedulerTask extends Model
 {
-  function Execute()
+  function Execute(): string
   {
+    return '';
   }
 }
 
-
 class ScheduleTaskTest extends SchedulerTask
 {
-  function Execute()
+  function Execute(): string
   {
     $Output = '#';