Changeset 887 for trunk/Modules/NetworkConfigRouterOS/Routerboard2.php

Timestamp:

Nov 20, 2020, 12:08:12 AM (4 years ago)

Author:

chronos

Message:

• Added: Static types added to almost all classes, methods and function. Supported by PHP 7.4.
• Fixed: Various found code issues.

File:

• trunk/Modules/NetworkConfigRouterOS/Routerboard2.php (modified) (5 diffs)

trunk/Modules/NetworkConfigRouterOS/Routerboard2.php

@@ -11 +11 @@
   );
 
-  function Execute($Commands)
+  function Execute($Commands): array
   {
     if (is_array($Commands)) $Commands = implode(';', $Commands);
@@ -17 +17 @@
   }
 
-  function GetItem($Command)
+  function GetItem($Command): array
   {
     $Result = $this->Execute($Command);
@@ -25 +25 @@
     {
       $ResultLineParts = explode(' ', trim($ResultLine));
-      if ($ResultLineParts[1]{0} == '"') $ResultLineParts[1] = substr($ResultLineParts[1], 1, -1); // Remove quotes
+      if ($ResultLineParts[1][0] == '"') $ResultLineParts[1] = substr($ResultLineParts[1], 1, -1); // Remove quotes
       $List[substr($ResultLineParts[0], 0, -1)] = $ResultLineParts[1];
     }
@@ -31 +31 @@
   }
 
-  function GetList($Command, $Properties)
+  function GetList($Command, $Properties): array
   {
     $PropertyList = '"';
@@ -55 +55 @@
   }
 
-  function GetSystemResource()
+  function GetSystemResource(): array
   {
     return $this->GetItem('/system resource print');
   }
 
-  function GetFirewallFilterList()
+  function GetFirewallFilterList(): array
   {
     return $this->GetList('/ip firewall nat', array('src-address', 'dst-address', 'bytes'));
   }
 
-  function GetDHCPServerLeasesList()
+  function GetDHCPServerLeasesList(): array
   {
     return $this->GetList('/ip dhcp-server lease', array('address', 'active-address', 'comment', 'lease-time', 'status', 'host-name'));