Changeset 887 for trunk/Modules/FinanceBankAPI/Fio.php

Timestamp:

Nov 20, 2020, 12:08:12 AM (4 years ago)

Author:

chronos

Message:

• Added: Static types added to almost all classes, methods and function. Supported by PHP 7.4.
• Fixed: Various found code issues.

File:

• trunk/Modules/FinanceBankAPI/Fio.php (modified) (2 diffs)

trunk/Modules/FinanceBankAPI/Fio.php

@@ -5 +5 @@
 class Fio
 {
-  var $UserName;
-  var $Password;
-  var $Account;
+  public string $UserName;
+  public string $Password;
+  public int $Account;
 
-  function Import($TimeFrom, $TimeTo)
+  function Import(int $TimeFrom, int $TimeTo): array
   {
     if ($this->UserName == '') throw new Exception('Missing value for UserName property.');
@@ -59 +59 @@
   }
 
-  function NoValidDataError($Response)
+  function NoValidDataError(array $Response): void
   {
     // Try to get error message
-    // If something go wrong fio show HTML login page and display error message
-  $Response = implode('', $Response);
+    // If something go wrong fio shows HTML login page and display error message
+    $Response = implode('', $Response);
     $ErrorMessageStart = '<div id="oldform_warning">';
     if (strpos($Response, $ErrorMessageStart) !== false)
-  {
-    $Response = substr($Response, strpos($Response, $ErrorMessageStart) + strlen($ErrorMessageStart));
-    $ErrorMessage = trim(substr($Response, 0, strpos($Response, '</div>')));
-  } else $ErrorMessage = '';
-  throw new Exception('No valid GPC data: '.$ErrorMessage);
+    {
+      $Response = substr($Response, strpos($Response, $ErrorMessageStart) + strlen($ErrorMessageStart));
+      $ErrorMessage = trim(substr($Response, 0, strpos($Response, '</div>')));
+    } else $ErrorMessage = '';
+    throw new Exception('No valid GPC data: '.$ErrorMessage);
   }
 }