Changeset 887 for trunk/Modules/FinanceBankAPI/FinanceBankAPI.php

Timestamp:

Nov 20, 2020, 12:08:12 AM (4 years ago)

Author:

chronos

Message:

• Added: Static types added to almost all classes, methods and function. Supported by PHP 7.4.
• Fixed: Various found code issues.

File:

• trunk/Modules/FinanceBankAPI/FinanceBankAPI.php (modified) (5 diffs)

trunk/Modules/FinanceBankAPI/FinanceBankAPI.php

@@ -8 +8 @@
 class ModuleFinanceBankAPI extends AppModule
 {
-  function __construct($System)
+  function __construct(System $System)
   {
     parent::__construct($System);
@@ -16 +16 @@
     $this->License = 'GNU/GPLv3';
     $this->Description = 'Communication through API to various banks, manual file import';
-    $this->Dependencies = array('Finance', 'Scheduler');
+    $this->Dependencies = array('Finance', 'Scheduler', 'IS');
   }
 
-  function DoInstall()
+  function DoInstall(): void
   {
   }
 
-  function DoUninstall()
+  function DoUninstall(): void
   {
   }
 
-  function DoStart()
+  function DoStart(): void
   {
     $this->System->FormManager->RegisterClass('ImportBankFile', array(
@@ -60 +60 @@
     ));
 
-    $this->System->RegisterPage(array('finance', 'import-api'), 'PageImportAPI');
-    $this->System->RegisterPage(array('finance', 'import-soubor'), 'PageImportFile');
+    $this->System->RegisterPage(['finance', 'import-api'], 'PageImportAPI');
+    $this->System->RegisterPage(['finance', 'import-soubor'], 'PageImportFile');
 
-    $this->System->ModuleManager->Modules['IS']->RegisterDashboardItem('FinanceBankAPI',
-      array('ModuleFinanceBankAPI', 'ShowDashboardItem'));
+    ModuleIS::Cast($this->System->GetModule('IS'))->RegisterDashboardItem('FinanceBankAPI',
+      array($this, 'ShowDashboardItem'));
   }
 
-  function DoStop()
+  function DoStop(): void
   {
   }
 
-  function ShowDashboardItem()
+  function ShowDashboardItem(): string
   {
     $DbResult = $this->Database->select('FinanceBankImport', 'COUNT(*)', '`FinanceOperation` IS NULL');
@@ -79 +79 @@
   }
 
-  function PresetItem($Item)
+  function PresetItem(array $Item): array
   {
     $Preset = array();
     if ($Item['Value'] < 0) $OperationGroupId = OPERATION_GROUP_ACCOUNT_OUT;
        else $OperationGroupId = OPERATION_GROUP_ACCOUNT_IN;
-    $FinanceGroup = $this->System->Modules['Finance']->GetFinanceGroupById($OperationGroupId, 'FinanceOperationGroup');
+    $FinanceGroup = ModuleFinance::Cast($this->System->GetModule('Finance'))->Finance->GetFinanceGroupById($OperationGroupId, 'FinanceOperationGroup');
 
     $Preset = array(
@@ -100 +100 @@
 class ScheduleBankImport extends SchedulerTask
 {
-  function Execute()
+  function Execute(): string
   {
     $Output = '';