Changeset 709

Timestamp:

Aug 21, 2025, 11:37:30 PM (3 hours ago)

Author:

chronos

Message:

• Added: Enter key confirms battle dialog window.
• Fixed: Potential battle dialog drawing issue.
• Modified: Code cleanup.

Location:

trunk/LocalPlayer

Files:

• Battle.pas (modified) (8 diffs)
• Draft.pas (modified) (5 diffs)
• Term.pas (modified) (1 diff)

trunk/LocalPlayer/Battle.pas

@@ -66 +66 @@
   MaxBar := 65;
 
-  // TerrType:=MyMap[ToLoc] and fTerrain;
+  // TerrType := MyMap[ToLoc] and fTerrain;
   GetUnitInfo(ToLoc, euix, UnitInfo);
 
@@ -171 +171 @@
   UnshareBitmap(Buffer);
   BitBltCanvas(Buffer.Canvas, 0, 0, 66, 48, ca, xm + 8 + 4, ym - 8 - 12 - 48);
-  { if TerrType<fForest then
-    Sprite(Buffer,HGrTerrain,0,16,66,32,1+TerrType*(xxt*2+1),1+yyt)
+  { if TerrType < fForest then
+    Sprite(Buffer, HGrTerrain, 0, 16, 66, 32, 1 + TerrType * (xxt * 2 + 1), 1 + yyt)
     else
     begin
-    Sprite(Buffer,HGrTerrain,0,16,66,32,1+2*(xxt*2+1),1+yyt+2*(yyt*3+1));
-    if (TerrType=fForest) and IsJungle(ToLoc div G.lx) then
-    Sprite(Buffer,HGrTerrain,0,16,66,32,1+7*(xxt*2+1),1+yyt+19*(yyt*3+1))
-    else Sprite(Buffer,HGrTerrain,0,16,66,32,1+7*(xxt*2+1),1+yyt+2*(2+TerrType-fForest)*(yyt*3+1));
+      Sprite(Buffer, HGrTerrain, 0, 16, 66, 32, 1 + 2 * (xxt * 2 + 1), 1 + yyt + 2 * (yyt * 3 + 1));
+      if (TerrType = fForest) and IsJungle(ToLoc div G.lx) then
+      Sprite(Buffer, HGrTerrain, 0, 16, 66, 32, 1 + 7 * (xxt * 2 + 1), 1+ yyt + 19 * (yyt * 3 + 1))
+      else Sprite(Buffer, HGrTerrain, 0, 16, 66, 32, 1 + 7 * (xxt * 2 + 1), 1 + yyt + 2 * (2 + TerrType - fForest) * (yyt * 3 + 1));
     end; }
   IsoMap.PaintUnit(1, 0, UnitInfo, 0);
@@ -201 +201 @@
 procedure TBattleDlg.FormShow(Sender: TObject);
 begin
-  if IsSuicideQuery then
-  begin
-    ClientWidth := 300;
-    ClientHeight := 288;
+  if IsSuicideQuery then begin
+    BoundsRect := Bounds(0, 0, 300, 288);
     OKBtn.Visible := True;
     CancelBtn.Visible := True;
     CenterToScreen;
-  end
-  else
-  begin
-    ClientWidth := 178;
-    ClientHeight := 178;
+  end else begin
+    BoundsRect := Bounds(0, 0, 178, 178);
     OKBtn.Visible := False;
     CancelBtn.Visible := False;
@@ -226 +221 @@
   begin
     Brush.Color := 0;
-    FillRect(Rect(0, 0, ClientWidth, ClientHeight));
+    FillRect(Rect(0, 0, Width, Height));
     Brush.Style := TBrushStyle.bsClear;
     PaintBackground(Canvas, 3 + Border, 3 + Border,
-      ClientWidth - (6 + 2 * Border), ClientHeight - (6 + 2 * Border),
-      ClientWidth, ClientHeight);
-  end;
-  Frame(Canvas, Border + 1, Border + 1, ClientWidth - (2 + Border),
-    ClientHeight - (2 + Border), MainTexture.ColorBevelLight,
+      Width - (6 + 2 * Border), Height - (6 + 2 * Border),
+      Width, Height);
+  end;
+  Frame(Canvas, Border + 1, Border + 1, Width - (2 + Border),
+    Height - (2 + Border), MainTexture.ColorBevelLight,
     MainTexture.ColorBevelShade);
-  Frame(Canvas, 2 + Border, 2 + Border, ClientWidth - (3 + Border),
-    ClientHeight - (3 + Border), MainTexture.ColorBevelLight,
+  Frame(Canvas, 2 + Border, 2 + Border, Width - (3 + Border),
+    Height - (3 + Border), MainTexture.ColorBevelLight,
     MainTexture.ColorBevelShade);
 
@@ -243 +238 @@
     Canvas.Font.Assign(UniFont[ftCaption]);
     S := Phrases.Lookup('TITLE_SUICIDE');
-    RisedTextOut(Canvas, (ClientWidth - BiColorTextWidth(Canvas, S)) div 2,
+    RisedTextOut(Canvas, (Width - BiColorTextWidth(Canvas, S)) div 2,
       7 + Border, S);
     Canvas.Font.Assign(UniFont[ftNormal]);
@@ -249 +244 @@
     P := Pos('\', S);
     if P = 0 then
-      RisedTextOut(Canvas, (ClientWidth - BiColorTextWidth(Canvas, S))
-        div 2, 205, S)
+      RisedTextOut(Canvas, (Width - BiColorTextWidth(Canvas, S)) div 2, 205, S)
     else
     begin
       s1 := Copy(S, 1, P - 1);
-      RisedTextOut(Canvas, (ClientWidth - BiColorTextWidth(Canvas, s1)) div 2,
+      RisedTextOut(Canvas, (Width - BiColorTextWidth(Canvas, s1)) div 2,
         205 - MessageLineSpacing div 2, s1);
       s1 := Copy(S, P + 1, 255);
-      RisedTextOut(Canvas, (ClientWidth - BiColorTextWidth(Canvas, s1)) div 2,
+      RisedTextOut(Canvas, (Width - BiColorTextWidth(Canvas, s1)) div 2,
         205 + (MessageLineSpacing - MessageLineSpacing div 2), s1);
     end;
@@ -263 +257 @@
   end
   else
-    ym := ClientHeight div 2;
+    ym := Height div 2;
   Canvas.Font.Assign(UniFont[ftSmall]);
-  PaintBattleOutcome(Canvas, ClientWidth div 2, ym, uix, ToLoc, Forecast);
+  PaintBattleOutcome(Canvas, Width div 2, ym, uix, ToLoc, Forecast);
 
   for cix := 0 to ControlCount - 1 do
@@ -293 +287 @@
   Shift: TShiftState);
 begin
+  if Key = VK_RETURN then OKBtnClick(Self)
+  else
   if not IsSuicideQuery and (Key <> VK_SHIFT) then
   begin

trunk/LocalPlayer/Draft.pas

@@ -415 +415 @@
 procedure TDraftDlg.SetDomain(D: Integer);
 
-  function Prio(fix: Integer): Integer;
+  function Prio(Fix: Integer): Integer;
   var
     FeaturePreq: Integer;
   begin
-    FeaturePreq := Feature[fix].Preq;
+    FeaturePreq := Feature[Fix].Preq;
     Assert(FeaturePreq <> preNA);
-    if fix < mcFirstNonCap then
-      Result := 10000 + fix
+    if Fix < mcFirstNonCap then
+      Result := 10000 + Fix
     else if FeaturePreq = preNone then
       Result := 20000
@@ -429 +429 @@
     else
       Result := 30000 + AdvValue[FeaturePreq];
-    if not (fix in AutoFeature) then
+    if not (Fix in AutoFeature) then
       Inc(Result, 90000);
   end;
@@ -471 +471 @@
 begin
   Domain := dGround;
-  while (Domain < dAir) and (upgrade[Domain, 0].Preq <> preNone) and
-    (MyRO.Tech[upgrade[Domain, 0].Preq] < tsApplicable) do
+  while (Domain < dAir) and (Upgrade[Domain, 0].Preq <> preNone) and
+    (MyRO.Tech[Upgrade[Domain, 0].Preq] < tsApplicable) do
     Inc(Domain);
 
@@ -478 +478 @@
   MaxLines := 0;
   for D := 0 to nDomains - 1 do
-    if (upgrade[D, 0].Preq = preNone) or
-      (MyRO.Tech[upgrade[D, 0].Preq] >= tsApplicable) then
+    if (Upgrade[D, 0].Preq = preNone) or
+      (MyRO.Tech[Upgrade[D, 0].Preq] >= tsApplicable) then
     begin
       Count := 0;
@@ -519 +519 @@
   begin
     for D := 0 to nDomains - 1 do
-      if (D <> Domain) and ((upgrade[D, 0].Preq = preNone) or
-        (MyRO.Tech[upgrade[D, 0].Preq] >= tsApplicable)) and
+      if (D <> Domain) and ((Upgrade[D, 0].Preq = preNone) or
+        (MyRO.Tech[Upgrade[D, 0].Preq] >= tsApplicable)) and
         (X >= xDomain + D * DomainPitch) and
         (X < xDomain + D * DomainPitch + 36) and (Y >= yDomain) and

trunk/LocalPlayer/Term.pas

@@ -2928 +2928 @@
           InitTurn(NewPlayer);
           DipMem[Me].pContact := -1;
-          (* if (Me=0) and (MyRO.Alive and (1 shl Me)=0)} then
+          (* if (Me = 0) and (MyRO.Alive and (1 shl Me) = 0)} then
             begin
-            if SimpleQuery(Phrases.Lookup('RESIGN'))=mrIgnore then
-            Server(sResign,Me,0,nil^)
-            else Server(sBreak,Me,0,nil^)
+            if SimpleQuery(Phrases.Lookup('RESIGN')) = mrIgnore then
+            Server(sResign, Me, 0, nil^)
+            else Server(sBreak, Me, 0, nil^)
             end
             else Play('TURNSTART'); *)