Changeset 323 for trunk/LocalPlayer

Timestamp:

Mar 23, 2021, 2:46:42 PM (4 years ago)

Author:

chronos

Message:

• Modified: Created single procedure for unshare/free bitmap before BitBlt use.

Location:

trunk/LocalPlayer

Files:

• CityScreen.pas (modified) (2 diffs)
• Draft.pas (modified) (1 diff)
• MessgEx.pas (modified) (2 diffs)

trunk/LocalPlayer/CityScreen.pas

@@ -259 +259 @@
     AgePrepared := MainTextureAge;
 
-    // TODO: FillRect should not be needed as BitBlt is with SRCCOPY
-    Back.Canvas.FillRect(0, 0, ClientWidth, ClientHeight);
-
+    UnshareBitmap(Back);
     BitBltCanvas(Back.Canvas, 0, 0, ClientWidth, ClientHeight,
       MainTexture.Image.Canvas, 0, 0);
@@ -358 +356 @@
 procedure TCityDlg.InitZoomCityMap;
 begin
-  // TODO: FillRect should not be needed as BitBlt is with SRCCOPY
-  ZoomCityMap.Canvas.FillRect(0, 0, ZoomCityMap.Width, ZoomCityMap.Height);
-
+  UnshareBitmap(ZoomCityMap);
   BitBltCanvas(ZoomCityMap.Canvas, 0, 0, wZoomMap, hZoomMap,
     Back.Canvas, xZoomMap, yZoomMap);

trunk/LocalPlayer/Draft.pas

@@ -233 +233 @@
 begin
   inherited;
-  // TODO: Explicitly clear background to black but in fact BitBlt SRCCOPY should do it
-  Back.Canvas.FillRect(0, 0, Back.Width, Back.Height);
+  UnshareBitmap(Back);
 
   ClientHeight := Template.Height - Cut;

trunk/LocalPlayer/MessgEx.pas

@@ -292 +292 @@
 
   // paint
-  // TODO: Explicitly clear background to black but in fact BitBlt SRCCOPY should do it
-  LogoBuffer.Canvas.FillRect(0, 0, LogoBuffer.Width, LogoBuffer.Height);
+  UnshareBitmap(LogoBuffer);
   BitBltCanvas(LogoBuffer.Canvas, 0, 0, BookRect.Width, BookRect.Height, ca, x, y);
 
@@ -374 +373 @@
       begin
         p1 := MyRO.Wonder[IconIndex].EffectiveOwner;
-        // TODO: Explicitly clear background to black but in fact BitBlt SRCCOPY should do it
-        Buffer.Canvas.FillRect(0, 0, 1, 1);
+        UnshareBitmap(Buffer);
         BitBltCanvas(Buffer.Canvas, 0, 0, xSizeBig + 2 * GlowRange,
           ySizeBig + 2 * GlowRange, Canvas,