Changeset 69 for branches/Transpascal/Forms

Timestamp:

Oct 19, 2010, 7:19:53 AM (15 years ago)

Author:

george

Message:

• Modified: Error messsage window reworked to use TListView instead of ListBox.
• Fixed: Focusing caret to position of error message source in code.
• Fixed: Loading other units during parsing.

Location:

branches/Transpascal/Forms

Files:

• UMainForm.pas (modified) (2 diffs)
• UMessagesForm.lfm (modified) (2 diffs)
• UMessagesForm.pas (modified) (4 diffs)

branches/Transpascal/Forms/UMainForm.pas

@@ -59 +59 @@
     ReopenLastOpenedFile: Boolean;
     procedure OpenRecentClick(Sender: TObject);
-    procedure LoadErrorMessages;
     procedure DockInit;
     procedure LoadFromRegistry;
@@ -112 +111 @@
 
   ProjectManager.TreeViewProjectChange(Self, ProjectManager.TreeViewProject.Selected);
-  LoadErrorMessages;
-end;
-
-procedure TMainForm.LoadErrorMessages;
-var
-  I: Integer;
-begin
-  with MessagesForm do begin
-    ListBoxMessages.Clear;
-    for I := 0 to Compiler.ErrorMessages.Count - 1 do
-    with TErrorMessage(Compiler.ErrorMessages[I]) do
-      ListBoxMessages.Items.Add(FileName + '(' + IntToStr(Position.X) +
-        ',' + IntToStr(Position.Y) + ') ' + Text);
-  end;
+  MessagesForm.Reload;
 end;
 

branches/Transpascal/Forms/UMessagesForm.lfm

@@ -8 +8 @@
   ClientWidth = 320
   LCLVersion = '0.9.29'
-  object ListBoxMessages: TListBox
+  object ListView1: TListView
     Left = 0
     Height = 240
@@ -14 +14 @@
     Width = 320
     Align = alClient
-    ItemHeight = 0
-    OnSelectionChange = ListBoxMessagesSelectionChange
+    Columns = <    
+      item
+        Caption = 'File'
+        Width = 80
+      end    
+      item
+        Caption = 'Position'
+      end    
+      item
+        Caption = 'Message'
+        Width = 500
+      end>
+    ItemIndex = -1
+    OwnerData = True
+    ReadOnly = True
+    RowSelect = True
     TabOrder = 0
+    ViewStyle = vsReport
+    OnClick = ListView1Click
+    OnData = ListView1Data
+    OnSelectItem = ListView1SelectItem
   end
   object CoolDockClient1: TCoolDockClient

branches/Transpascal/Forms/UMessagesForm.pas

@@ -7 +7 @@
 uses
   Classes, SysUtils, FileUtil, Forms, Controls, Graphics, Dialogs, StdCtrls,
-  UCoolDocking, UProject, UCompiler;
+  ComCtrls, UCoolDocking, UProject, UCompiler;
 
 type
@@ -15 +15 @@
   TMessagesForm = class(TForm)
     CoolDockClient1: TCoolDockClient;
-    ListBoxMessages: TListBox;
+    ListView1: TListView;
     procedure ListBoxMessagesSelectionChange(Sender: TObject; User: boolean);
+    procedure ListView1Click(Sender: TObject);
+    procedure ListView1Data(Sender: TObject; Item: TListItem);
+    procedure ListView1SelectItem(Sender: TObject; Item: TListItem;
+      Selected: Boolean);
   private
     { private declarations }
   public
-    { public declarations }
+    procedure Reload;
   end; 
 
@@ -37 +41 @@
 procedure TMessagesForm.ListBoxMessagesSelectionChange(Sender: TObject;
   User: boolean);
+begin
+
+end;
+
+procedure TMessagesForm.ListView1Click(Sender: TObject);
+begin
+  ListView1SelectItem(Self, ListView1.Selected, ListView1.Selected.Selected);
+end;
+
+procedure TMessagesForm.ListView1Data(Sender: TObject; Item: TListItem);
+begin
+  with MainForm, CodeForm do
+  with TErrorMessage(Compiler.ErrorMessages[Item.Index]) do begin
+    Item.Caption := FileName;
+    Item.Data := Compiler.ErrorMessages[Item.Index];
+    Item.SubItems.Add(IntToStr(Position.X) + ',' + IntToStr(Position.Y));
+    Item.SubItems.Add(Text);
+  end;
+end;
+
+procedure TMessagesForm.ListView1SelectItem(Sender: TObject; Item: TListItem;
+  Selected: Boolean);
 var
   ProjectFile: TProjectFile;
 begin
   with MainForm, CodeForm do
-  if ListBoxMessages.ItemIndex <> -1 then
-  with TErrorMessage(Compiler.ErrorMessages[ListBoxMessages.ItemIndex]) do begin
+  if Assigned(ListView1.Selected) then
+  with TErrorMessage(ListView1.Selected.Data) do begin
     ProjectFile := Project.SearchFile(FileName);
     if Assigned(ProjectFile) then
@@ -52 +78 @@
 end;
 
+procedure TMessagesForm.Reload;
+begin
+  ListView1.Items.Count := MainForm.Compiler.ErrorMessages.Count;
+  ListView1.Refresh;
+end;
+
 end.