Changeset 264 for ExceptionLogger/UStackTrace.pas

Timestamp:

Aug 17, 2011, 10:08:55 AM (13 years ago)

Author:

george

Message:

• Modified: Now detailed info is displayed after user click Details. User will see at first only necessary error message.
• Modified: Now methods in TStackTrace class loads call stack and exception stack only as list of frame address. Then delayed GetInfo method should be called to fully load call stack debug information. This is useful in case of external debug file where loading time could be significant.

File:

• ExceptionLogger/UStackTrace.pas (modified) (4 diffs)

ExceptionLogger/UStackTrace.pas

@@ -22 +22 @@
 
   TStackTrace = class(TObjectList)
+    Frames: array of Pointer;
     MaxDepth: Integer;
     procedure GetExceptionBackTrace;
     procedure GetCallStack(BP: Pointer);
     procedure GetCurrentCallStack;
+    procedure GetInfo;
     constructor Create;
   end;
@@ -66 +68 @@
   try
     I := 0;
+    SetLength(Frames, 0);
     while (BP <> nil) and (I < MaxDepth) do begin
-      CallerAddress := TStackFrameInfo(get_caller_addr(BP));
-      StackFrameInfo := TStackFrameInfo.Create;
-      StackFrameInfo.GetFrameInfo(CallerAddress);
-      StackFrameInfo.Index := I + 1;
-      Add(StackFrameInfo);
+      SetLength(Frames, Length(Frames) + 1);
+      Frames[I] := TStackFrameInfo(get_caller_addr(BP));
       Inc(I);
       BP := TStackFrameInfo(get_caller_frame(BP));
@@ -89 +89 @@
 var
   FrameCount: Integer;
-  Frames: PPointer;
+  FramesList: PPointer;
   FrameNumber: Integer;
-  StackFrameInfo: TStackFrameInfo;
 begin
-  Clear;
-  StackFrameInfo := TStackFrameInfo.Create;
-  StackFrameInfo.GetFrameInfo(ExceptAddr);
-  StackFrameInfo.Index := 1;
-  Add(StackFrameInfo);
+  SetLength(Frames, 1);
+  Frames[0] := ExceptAddr;
   FrameCount := ExceptFrameCount;
-  Frames := ExceptFrames;
+  FramesList := ExceptFrames;
   if FrameCount > MaxDepth then FrameCount := MaxDepth;
+  SetLength(Frames, FrameCount + 1);
   for FrameNumber := 0 to FrameCount - 1 do begin
-    StackFrameInfo := TStackFrameInfo.Create;
-    StackFrameInfo.GetFrameInfo(Frames[FrameNumber]);
-    StackFrameInfo.Index := FrameNumber + 1;
-    Add(StackFrameInfo);
+    Frames[FrameNumber + 1] := FramesList[FrameNumber]
   end;
 end;
@@ -114 +108 @@
 end;
 
+procedure TStackTrace.GetInfo;
+var
+  I: Integer;
+  StackFrameInfo: TStackFrameInfo;
+begin
+  Clear;
+  for I := 0 to High(Frames) do begin
+    StackFrameInfo := TStackFrameInfo.Create;
+    StackFrameInfo.GetFrameInfo(Frames[I]);
+    StackFrameInfo.Index := I + 1;
+    Add(StackFrameInfo);
+  end;
+end;
+
 end.