Changeset 28 for trunk/Forms/UFormTables.pas

Timestamp:

Sep 10, 2022, 10:21:48 PM (2 years ago)

Author:

chronos

Message:

• Modified: Do not create all application forms at initialization phase but dynamically.

File:

• trunk/Forms/UFormTables.pas (modified) (13 diffs)

trunk/Forms/UFormTables.pas

@@ -18 +18 @@
     ARemove: TAction;
     ActionList1: TActionList;
-    ListView1: TListView;
+    ListViewTables: TListView;
     MenuItem1: TMenuItem;
     MenuItem2: TMenuItem;
@@ -39 +39 @@
     procedure FormDestroy(Sender: TObject);
     procedure FormShow(Sender: TObject);
-    procedure ListView1Data(Sender: TObject; Item: TListItem);
-    procedure ListView1SelectItem(Sender: TObject; Item: TListItem;
+    procedure ListViewTablesData(Sender: TObject; Item: TListItem);
+    procedure ListViewTablesSelectItem(Sender: TObject; Item: TListItem;
       Selected: Boolean);
   private
@@ -53 +53 @@
   end;
 
-var
-  FormTables: TFormTables;
-
 
 implementation
@@ -71 +68 @@
 { TFormTables }
 
-procedure TFormTables.ListView1Data(Sender: TObject; Item: TListItem);
+procedure TFormTables.ListViewTablesData(Sender: TObject; Item: TListItem);
 begin
   if (Item.Index >= 0) and (Item.Index < FTables.Count) then
   with TTable(FTables[Item.Index]) do begin
     Item.Caption := Caption;
-    Item.SubItems.Add(IntToStr(RecordsCount));
+    Item.SubItems.Add(IntToStr(RecordsCount) + ' ' + IntToStr(Fields.Count));
     Item.Data := FTables[Item.Index];
   end
 end;
 
-procedure TFormTables.ListView1SelectItem(Sender: TObject; Item: TListItem;
+procedure TFormTables.ListViewTablesSelectItem(Sender: TObject; Item: TListItem;
   Selected: Boolean);
 begin
@@ -97 +94 @@
 procedure TFormTables.UpdateInterface;
 begin
-  ListView1.Enabled := Assigned(Tables);
-  AAdd.Enabled := Assigned(Tables);
-  AModify.Enabled := Assigned(Tables) and Assigned(ListView1.Selected);
-  ARemove.Enabled := Assigned(Tables) and Assigned(ListView1.Selected);
-  AShowRecords.Enabled := Assigned(Tables) and Assigned(ListView1.Selected);
-  AShowFields.Enabled := Assigned(Tables) and Assigned(ListView1.Selected);
+  ListViewTables.Enabled := Assigned(Tables) and Assigned(FDbClient);
+  AAdd.Enabled := Assigned(Tables) and Assigned(FDbClient);
+  AModify.Enabled := Assigned(Tables) and Assigned(ListViewTables.Selected) and Assigned(FDbClient);
+  ARemove.Enabled := Assigned(Tables) and Assigned(ListViewTables.Selected) and Assigned(FDbClient);
+  AShowRecords.Enabled := Assigned(Tables) and Assigned(ListViewTables.Selected) and Assigned(FDbClient);
+  AShowFields.Enabled := Assigned(Tables) and Assigned(ListViewTables.Selected) and Assigned(FDbClient);
 end;
 
@@ -112 +109 @@
   NewTable.Name := SNewTable;
   NewTable.DbClient := Tables.DbClient;
-  FormTable.Load(NewTable);
-  if FormTable.ShowModal = mrOk then begin
-    FormTable.Save(NewTable);
-    Tables.DbClient.Query('INSERT INTO Model ( Name , Caption ) VALUES ( ' +
-      NewTable.Name + ' , ' + NewTable.Caption + ' )');
-    ReloadList;
-  end else NewTable.Free;
+  with TFormTable.Create(nil) do
+  try
+    Load(NewTable);
+    if ShowModal = mrOk then begin
+      Save(NewTable);
+      Tables.DbClient.Query('INSERT INTO Model ( Name , Caption ) VALUES ( ' +
+        NewTable.Name + ' , ' + NewTable.Caption + ' )');
+      ReloadList;
+    end else NewTable.Free;
+  finally
+    Free;
+  end;
 end;
 
 procedure TFormTables.AModifyExecute(Sender: TObject);
 begin
-  if Assigned(ListView1.Selected) then begin
-    FormTable.Load(TTable(ListView1.Selected.Data));
-    if FormTable.ShowModal = mrOk then begin
-      FormTable.Save(TTable(ListView1.Selected.Data));
-      DbClient.Query('UPDATE Model SET Caption = ' + TTable(ListView1.Selected.Data).Caption + ' WHERE Name = ' + TTable(ListView1.Selected.Data).Name);
-      ReloadList;
+  if Assigned(ListViewTables.Selected) then begin
+    with TFormTable.Create(nil) do
+    try
+      Load(TTable(ListViewTables.Selected.Data));
+      if ShowModal = mrOk then begin
+        Save(TTable(ListViewTables.Selected.Data));
+        DbClient.Query('UPDATE Model SET Caption = ' + TTable(ListViewTables.Selected.Data).Caption + ' WHERE Name = ' + TTable(ListViewTables.Selected.Data).Name);
+        ReloadList;
+      end;
+    finally
+      Free;
     end;
   end;
@@ -135 +142 @@
 procedure TFormTables.ARemoveExecute(Sender: TObject);
 begin
-  if Assigned(ListView1.Selected) then begin
-    if MessageDlg(SRemoveTable, Format(SRemoveTableConfirm, [TTable(ListView1.Selected.Data).Caption]),
+  if Assigned(ListViewTables.Selected) then begin
+    if MessageDlg(SRemoveTable, Format(SRemoveTableConfirm, [TTable(ListViewTables.Selected.Data).Caption]),
     mtConfirmation, [mbYes, mbNo], 0) = mrYes then begin
-      Tables.DbClient.Query('DELETE FROM Model WHERE Name = ' + TTable(ListView1.Selected.Data).Name);
+      Tables.DbClient.Query('DELETE FROM Model WHERE Name = ' + TTable(ListViewTables.Selected.Data).Name);
       ReloadList;
     end;
@@ -152 +159 @@
   OldField: TField;
   OldTable: TTable;
-begin
-  if Assigned(ListView1.Selected) then begin
-    OldTable := TTable(ListView1.Selected.Data);
+  FormFields: TFormFields;
+begin
+  if Assigned(ListViewTables.Selected) then begin
+    OldTable := TTable(ListViewTables.Selected.Data);
+    FormFields := TFormFields.Create(nil);
     FormFields.TableName := OldTable.Caption;
     FormFields.Fields := TFields.Create;
@@ -160 +169 @@
     FormFields.Fields.Assign(OldTable.Fields);
     for I := 0 to FormFields.Fields.Count - 1 do
-      TField(FormFields.Fields[I]).Table := TField(OldTable.Fields[I]).Table;
+      FormFields.Fields[I].Table := OldTable.Fields[I].Table;
     if FormFields.ShowModal = mrOk then begin
       // Inefficient way to update table data. Copy original columns to new records and
@@ -168 +177 @@
       for I := 0 to NewRecords.Count - 1 do begin
         NewRecords.Items[I] := TRecord.Create;
-        TRecord(NewRecords.Items[I]).Values.Count := FormFields.Fields.Count;
+        NewRecords[I].Values.Count := FormFields.Fields.Count;
         for C := 0 to FormFields.Fields.Count - 1 do
-          TRecord(NewRecords.Items[I]).Values[C] := TField(FormFields.Fields[C]).GetValueClass.Create;
+          NewRecords[I].Values[C] := FormFields.Fields[C].GetValueClass.Create;
       end;
       for C := 0 to FormFields.Fields.Count - 1 do begin
-        OldField := OldTable.Fields.SearchByName(TField(FormFields.Fields[C]).Name);
+        OldField := OldTable.Fields.SearchByName(FormFields.Fields[C].Name);
         if Assigned(OldField) then begin
           FI := OldTable.Fields.IndexOf(OldField);
           for I := 0 to NewRecords.Count - 1 do
-            TValue(TRecord(NewRecords[I]).Values[C]).Assign(TValue(TRecord(OldTable.Records[I]).Values[FI]));
+            NewRecords[I].Values[C].Assign(OldTable.Records[I].Values[FI]);
         end;
       end;
@@ -186 +195 @@
     end;
     FormFields.Fields.Free;
+    FormFields.Free;
   end;
 end;
@@ -191 +201 @@
 procedure TFormTables.AShowRecordsExecute(Sender: TObject);
 begin
-  if Assigned(ListView1.Selected) then begin
-    FormRecords.Table := TTable(ListView1.Selected.Data);
-    FormRecords.ShowModal;
+  if Assigned(ListViewTables.Selected) then begin
+    with TFormRecords.Create(nil) do
+    try
+      Table := TTable(ListViewTables.Selected.Data);
+      ShowModal;
+    finally
+      Free;
+    end;
     ReloadList;
   end;
@@ -227 +242 @@
   if Assigned(DbClient) then begin
     DbRows := TDbRows.Create;
-    DbClient.Query('SELECT * FROM Model', DbRows);
-    for I := 0 to DbRows.Count - 1 do begin
-      NewTable := Tables.AddNew(DbRows[I].Items['Name']);
-      NewTable.Caption := DbRows[I].Items['Caption'];
-    end;
-    DbRows.Free;
+    try
+      DbClient.Query('SELECT * FROM Model', DbRows);
+      for I := 0 to DbRows.Count - 1 do begin
+        NewTable := Tables.AddNew(DbRows[I].Items['Name']);
+        NewTable.Caption := DbRows[I].Items['Caption'];
+      end;
+    finally
+      DbRows.Free;
+    end;
   end;
 
   for I := 0 to Tables.Count - 1 do
-    TTable(Tables[I]).LoadRecordsCount;
+    Tables[I].LoadRecordsCount;
   if Assigned(Tables) then begin
-    ListView1.Items.Count := Tables.Count;
-    ListView1.Repaint;
-  end else ListView1.Items.Count := 0;
+    ListViewTables.Items.Count := Tables.Count;
+    ListViewTables.Repaint;
+  end else ListViewTables.Items.Count := 0;
   UpdateInterface;
 end;