Changeset 916 for trunk/Modules/Finance/Manage.php

Timestamp:

Dec 7, 2021, 11:08:42 PM (2 years ago)

Author:

chronos

Message:

• Added: Allow to switch Mail class into test mode.
• Modified: Type checking related changes.
• Modified: Replace global $Config references with $this->System->Config is possible.

File:

• trunk/Modules/Finance/Manage.php (modified) (11 diffs)

trunk/Modules/Finance/Manage.php

@@ -49 +49 @@
 
   /* Get first day and last day of given billing period. Periods are aligned with year start/end. */
-  function GetBillingPeriod($Period)
+  function GetBillingPeriod(int $Period): array
   {
     $Time = time();
@@ -73 +73 @@
   }
 
-  function ShowMonthlyPayment()
+  function ShowMonthlyPayment(): string
   {
     if (!ModuleUser::Cast($this->System->GetModule('User'))->User->CheckPermission('Finance', 'Manage')) return 'Nemáte oprávnění';
@@ -126 +126 @@
   }
 
-  function InsertInvoice($Subject, $TimeCreation, $TimeDue, $Items,
-    $Group, $PeriodFrom, $PeriodTo)
+  function InsertInvoice(string $Subject, string $TimeCreation, string $TimeDue, array $Items,
+    array $Group, float $PeriodFrom, float $PeriodTo): string
   {
     global $LastInsertTime;
@@ -156 +156 @@
   }
 
-  function ProduceInvoices()
+  function ProduceInvoices(): string
   {
     $Output = '';
@@ -224 +224 @@
   }
 
-  function TableUpdateChanges($Table)
+  function TableUpdateChanges(string $Table): void
   {
     $Time = time();
@@ -256 +256 @@
   }
 
-  function ProcessTableUpdates()
+  function ProcessTableUpdates(): string
   {
     // Update customers
@@ -277 +277 @@
   }
 
-  function ProcessMonthlyPayment()
+  function ProcessMonthlyPayment(): string
   {
     if (!ModuleUser::Cast($this->System->GetModule('User'))->User->CheckPermission('Finance', 'Manage')) return 'Nemáte oprávnění';
@@ -344 +344 @@
   }
 
-  function SendPaymentEmail($MemberId, $FileId = '')
+  function SendPaymentEmail(string $MemberId, string $FileId = ''): string
   {
     global $Config;
@@ -418 +418 @@
   }
 
-  function GenerateInvoice($Where)
+  function GenerateInvoice(string $Where): string
   {
     $DirectoryId = ModuleFinance::Cast($this->System->GetModule('Finance'))->Finance->DirectoryId;
@@ -447 +447 @@
   }
 
-  function GenerateOperation($Where)
+  function GenerateOperation(string $Where): string
   {
     $DirectoryId = ModuleFinance::Cast($this->System->GetModule('Finance'))->Finance->DirectoryId;
@@ -476 +476 @@
   }
 
-  function GenerateBills()
+  function GenerateBills(): string
   {
     $Output = '';