Changeset 805 for trunk/Modules/Log

Timestamp:

May 24, 2014, 11:35:47 PM (11 years ago)

Author:

chronos

Message:

• Fixed: Do not log client proxy IP address as remote address because it can be faked and also there can be multiple client proxy addresses.
• Modified: Do not use directly $_SERVER variables REMOTE_ADDR and REQUEST_URI as they are not initialized if script is executed from command line.
• Fixed: Default configuration was not complete.

File:

• trunk/Modules/Log/Log.php (modified) (2 diffs)

trunk/Modules/Log/Log.php

@@ -33 +33 @@
   function WriteLog($Text, $Type)
   {
-        if(!isset($_SERVER['REMOTE_ADDR'])) $IP = 'Konzole';
-          else $IP = addslashes($_SERVER['REMOTE_ADDR']);
-        
-        if(isset($this->System->User) and !is_null($this->System->User->Id)) $UserId = $this->System->User->Id;
+        if(isset($this->System->User) and !is_null($this->System->User->Id)) 
+          $UserId = $this->System->User->Id;
           else $UserId = 'NULL';
         $Query = 'INSERT INTO `Log` ( `User` , `Type` , `Text` , `Date` , `IP`, `URL` ) '.
-                'VALUES ('.$UserId.', '.$Type.', "'.addslashes($Text).'", NOW(), "'.$IP.'", "'.$_SERVER['REQUEST_URI'].'")';
+          'VALUES ('.$UserId.', '.$Type.', "'.addslashes($Text).'", NOW(), "'.
+          GetRemoteAddress().'", "'.GetRequestURI().'")';
         $this->System->Database->query($Query);
   }
@@ -60 +59 @@
 {
         global $System, $User;
-
-        if(!isset($_SERVER['REMOTE_ADDR'])) $IP = 'Konzole';
-          else $IP = addslashes($_SERVER['REMOTE_ADDR']);
-
+        
         if(isset($User) and !is_null($User->Id)) $UserId = $User->Id;
           else $UserId = 'NULL';
         $Query = 'INSERT INTO `Log` ( `User` , `Type` , `Text` , `Date` , `IP`, `URL` ) '.
-          'VALUES ('.$UserId.', '.$Type.', "'.addslashes($Text).'", NOW(), "'.$IP.'", "'.$_SERVER['REQUEST_URI'].'")';
+          'VALUES ('.$UserId.', '.$Type.', "'.addslashes($Text).'", NOW(), "'.
+      GetRemoteAddress().'", "'.GetRequestURI().'")';
         $System->Database->query($Query);
 }