Changeset 108 for trunk/Forms

Timestamp:

Feb 11, 2022, 11:31:42 AM (3 years ago)

Author:

chronos

Message:

• Fixed: Do not update interface in contact properties if the listview doesn't have handle yet.
• Added: Synced update of full name and name parts in contact form.
• Modified: Improved image loading code by image format.

Location:

trunk/Forms

Files:

• UFormContact.lfm (modified) (6 diffs)
• UFormContact.pas (modified) (5 diffs)
• UFormContacts.pas (modified) (1 diff)
• UFormMain.lfm (modified) (1 diff)
• UFormProperties.pas (modified) (5 diffs)

trunk/Forms/UFormContact.lfm

@@ -43 +43 @@
         Top = 75
         Width = 161
+        OnChange = NamePartChange
         ParentFont = False
         TabOrder = 1
@@ -95 +96 @@
       end
       object EditLastName: TEdit
-        Left = 699
+        Left = 700
         Height = 43
         Top = 75
         Width = 161
+        OnChange = NamePartChange
         ParentFont = False
         TabOrder = 2
@@ -167 +169 @@
         Top = 125
         Width = 161
+        OnChange = NamePartChange
         ParentFont = False
         TabOrder = 4
@@ -179 +182 @@
       end
       object EditTitleBefore: TEdit
-        Left = 375
+        Left = 376
         Height = 43
         Top = 175
         Width = 161
+        OnChange = NamePartChange
         ParentFont = False
         TabOrder = 5
@@ -199 +203 @@
         Top = 175
         Width = 161
+        OnChange = NamePartChange
         ParentFont = False
         TabOrder = 6
@@ -699 +704 @@
         Width = 920
         Caption = 'Address'
-        ClientHeight = 255
+        ClientHeight = 281
         ClientWidth = 918
         TabOrder = 9

trunk/Forms/UFormContact.pas

@@ -205 +205 @@
     procedure ButtonWorkAddressShowClick(Sender: TObject);
     procedure EditFullNameChange(Sender: TObject);
+    procedure NamePartChange(Sender: TObject);
     procedure FormClose(Sender: TObject; var CloseAction: TCloseAction);
     procedure FormCreate(Sender: TObject);
@@ -315 +316 @@
   {$ENDIF}
   Core.PersistentForm1.Load(Self);
-
-  FormProperties.ManualDock(TabSheetAll, nil, alClient);
-  FormProperties.Align := alClient;
-  FormProperties.Show;
-
   PhotoChange(nil);
 
-  PageControlContact.TabIndex := Core.LastContactTabIndex;
-  UpdateInterface;
+  FormProperties.BeginUpdate;
+  try
+
+    FormProperties.ManualDock(TabSheetAll, nil, alClient);
+    FormProperties.Align := alClient;
+    FormProperties.Show;
+
+    PageControlContact.TabIndex := Core.LastContactTabIndex;
+    UpdateInterface;
+  finally
+    FormProperties.EndUpdate;
+  end;
 end;
 
@@ -385 +391 @@
 procedure TFormContact.TabSheetAllShow(Sender: TObject);
 begin
-  FormProperties.Properties := Contact.Properties;
-  FormProperties.ReloadList;
-  FormProperties.UpdateInterface;
+  FormProperties.BeginUpdate;
+  try
+    FormProperties.Properties := Contact.Properties;
+    FormProperties.ReloadList;
+    FormProperties.UpdateInterface;
+    FormProperties.Show;
+  finally
+    FormProperties.EndUpdate;
+  end;
 end;
 
@@ -709 +721 @@
 end;
 
+procedure UpdateEditNoOnChange(Edit: TEdit; Text: string);
+var
+  LastHandler: TNotifyEvent;
+begin
+  LastHandler := Edit.OnChange;
+  Edit.OnChange := nil;
+  try
+    Edit.Text := Text;
+  finally
+    Edit.OnChange := LastHandler;
+  end;
+end;
+
 procedure TFormContact.EditFullNameChange(Sender: TObject);
-begin
+var
+
+  Before, First, Middle, Last, After: string;
+begin
+  Contact.FullNameToNameParts(EditFullName.Text, Before, First, Middle, Last, After);
+  UpdateEditNoOnChange(EditTitleBefore, Before);
+  UpdateEditNoOnChange(EditFirstName, First);
+  UpdateEditNoOnChange(EditMiddleName, Middle);
+  UpdateEditNoOnChange(EditLastName, Last);
+  UpdateEditNoOnChange(EditTitleAfter, After);
   UpdateInterface;
+end;
+
+procedure TFormContact.NamePartChange(Sender: TObject);
+begin
+  UpdateEditNoOnChange(EditFullName, Contact.NamePartsToFullName(EditTitleBefore.Text,
+    EditFirstName.Text, EditMiddleName.Text, EditLastName.Text, EditTitleAfter.Text));
 end;
 
@@ -732 +772 @@
 
 procedure TFormContact.UpdateInterface;
-begin
-  Caption := EditFullName.Text + ' - ' + SContact;
+var
+  Title: string;
+begin
+  Title := SContact;
+  if EditFullName.Text <> '' then Title := EditFullName.Text + ' - ' + Title
+  else
+  if EditOrganization.Text <> '' then Title := EditOrganization.Text + ' - ' + Title;
+  Caption := Title;
   APhotoSave.Enabled := FPhoto.Used;
   APhotoClear.Enabled := FPhoto.Used;

trunk/Forms/UFormContacts.pas

@@ -260 +260 @@
   Selected: Boolean;
 begin
+  if not ListView1.HandleAllocated then Exit;
+
   Selected := Assigned(ListView1.Selected);
   AAdd.Enabled := Assigned(Contacts);

trunk/Forms/UFormMain.lfm

@@ -1 +1 @@
 object FormMain: TFormMain
-  Left = 601
+  Left = 553
   Height = 829
-  Top = 447
+  Top = 401
   Width = 1227
   Caption = 'vCard Studio'

trunk/Forms/UFormProperties.pas

@@ -65 +65 @@
   private
     FProperties: TContactProperties;
+    FUpdateCount: Integer;
     procedure FilterList(List: TFPGObjectList<TObject>);
     procedure SetProperties(AValue: TContactProperties);
+    procedure DoUpdateInterface;
   public
     property Properties: TContactProperties read FProperties write SetProperties;
     procedure ReloadList;
+    procedure BeginUpdate;
+    procedure EndUpdate;
     procedure UpdateInterface;
   end;
@@ -93 +97 @@
   STextFiles = 'Text files';
   SValue = 'Value';
+  SEndUpdateTooLow = 'Update counter error';
 
 const
@@ -365 +370 @@
 end;
 
-procedure TFormProperties.UpdateInterface;
+procedure TFormProperties.BeginUpdate;
+begin
+  Inc(FUpdateCount);
+end;
+
+procedure TFormProperties.EndUpdate;
+begin
+  if FUpdateCount <= 0 then raise Exception(SEndUpdateTooLow);
+  Dec(FUpdateCount);
+  if FUpdateCount = 0 then DoUpdateInterface;
+end;
+
+procedure TFormProperties.DoUpdateInterface;
 var
   Text: string;
@@ -371 +388 @@
   Selected: Boolean;
 begin
+  if not ListView1.HandleAllocated then Exit;
+
   Selected := Assigned(ListView1.Selected);
   AAdd.Enabled := Assigned(Properties);
@@ -392 +411 @@
 end;
 
+procedure TFormProperties.UpdateInterface;
+begin
+  if FUpdateCount = 0 then DoUpdateInterface;
+end;
+
 end.