Changeset 104 for trunk/Forms

Timestamp:

Feb 9, 2022, 5:07:14 PM (3 years ago)

Author:

chronos

Message:

• Modified: Updated speed of loading of big number of contacts.
• Added: Contact field indexes cache for faster reverse search of contact fields by its index.

Location:

trunk/Forms

Files:

• UFormContact.pas (modified) (2 diffs)
• UFormContacts.pas (modified) (3 diffs)
• UFormProperties.pas (modified) (1 diff)
• UFormTest.pas (modified) (1 diff)

trunk/Forms/UFormContact.pas

@@ -685 +685 @@
   if EditHomeAddressCity.Text <> '' then Address := Address + ' ' + EditHomeAddressCity.Text;
   if EditHomeAddressCountry.Text <> '' then Address := Address + ' ' + EditHomeAddressCountry.Text;
-  OpenURL(Core.MapUrl + URLEncode(Trim(Address)));
+  if Trim(Address) <> '' then
+    OpenURL(Core.MapUrl + URLEncode(Trim(Address)));
 end;
 
@@ -704 +705 @@
   if EditWorkAddressCity.Text <> '' then Address := Address + ' ' + EditWorkAddressCity.Text;
   if EditWorkAddressCountry.Text <> '' then Address := Address + ' ' + EditWorkAddressCountry.Text;
-  OpenURL(Core.MapUrl + URLEncode(Trim(Address)));
+  if Trim(Address) <> '' then
+    OpenURL(Core.MapUrl + URLEncode(Trim(Address)));
 end;
 

trunk/Forms/UFormContacts.pas

@@ -258 +258 @@
   Text: string;
   SelectedCount: Integer;
-begin
+  Selected: Boolean;
+begin
+  Selected := Assigned(ListView1.Selected);
   AAdd.Enabled := Assigned(Contacts);
-  AModify.Enabled := Assigned(Contacts) and Assigned(ListView1.Selected);
-  ARemove.Enabled := Assigned(Contacts) and Assigned(ListView1.Selected);
+  AModify.Enabled := Assigned(Contacts) and Selected;
+  ARemove.Enabled := Assigned(Contacts) and Selected;
+  AAdd.Enabled := Assigned(Contacts);
+  AModify.Enabled := Assigned(Contacts) and Selected;
+  AClone.Enabled := Assigned(Contacts) and Selected;
+  ARemove.Enabled := Assigned(Contacts) and Selected;
+  ASelectAll.Enabled := ListView1.Items.Count > 0;
+  ALoadFromFile.Enabled := Assigned(Contacts) and Selected;
+  ASaveToFile.Enabled := Assigned(Contacts) and Selected;
+  ACopy.Enabled := Assigned(Contacts) and Selected;
+  ACut.Enabled := Assigned(Contacts) and Selected;
+  APaste.Enabled := Assigned(Contacts) and (Clipboard.AsText <> '');
 
   Text := '';
@@ -273 +285 @@
   end;
   StatusBar1.Panels[0].Text := Text;
+
+  UpdateColumns;
 end;
 
@@ -613 +627 @@
 begin
   if FUpdateCount = 0 then DoUpdateInterface;
-  AAdd.Enabled := Assigned(Contacts);
-  AModify.Enabled := Assigned(Contacts) and Assigned(ListView1.Selected);
-  AClone.Enabled := Assigned(Contacts) and Assigned(ListView1.Selected);
-  ARemove.Enabled := Assigned(Contacts) and Assigned(ListView1.Selected);
-  ASelectAll.Enabled := ListView1.Items.Count > 0;
-  ALoadFromFile.Enabled := Assigned(Contacts) and Assigned(ListView1.Selected);
-  ASaveToFile.Enabled := Assigned(Contacts) and Assigned(ListView1.Selected);
-  ACopy.Enabled := Assigned(Contacts) and Assigned(ListView1.Selected);
-  ACut.Enabled := Assigned(Contacts) and Assigned(ListView1.Selected);
-  APaste.Enabled := Assigned(Contacts) and (Clipboard.AsText <> '');
-
-  UpdateColumns;
 end;
 

trunk/Forms/UFormProperties.pas

@@ -369 +369 @@
   Text: string;
   SelectedCount: Integer;
-begin
+  Selected: Boolean;
+begin
+  Selected := Assigned(ListView1.Selected);
   AAdd.Enabled := Assigned(Properties);
-  AModify.Enabled := Assigned(Properties) and Assigned(ListView1.Selected);
-  AClone.Enabled := Assigned(Properties) and Assigned(ListView1.Selected);;
-  ARemove.Enabled := Assigned(Properties) and Assigned(ListView1.Selected);
-  ALoadValueFromFile.Enabled := Assigned(Properties) and Assigned(ListView1.Selected);
-  ASaveValueToFile.Enabled := Assigned(Properties) and Assigned(ListView1.Selected);
+  AModify.Enabled := Assigned(Properties) and Selected;
+  AClone.Enabled := Assigned(Properties) and Selected;
+  ARemove.Enabled := Assigned(Properties) and Selected;
+  ALoadValueFromFile.Enabled := Assigned(Properties) and Selected;
+  ASaveValueToFile.Enabled := Assigned(Properties) and Selected;
   ASelectAll.Enabled := ListView1.Items.Count > 0;
 

trunk/Forms/UFormTest.pas

@@ -76 +76 @@
 
 procedure TFormTest.UpdateInterface;
-begin
-  ARun.Enabled := Assigned(ListViewTestCases.Selected);
-  AShow.Enabled := Assigned(ListViewTestCases.Selected);
+var
+  Selected: Boolean;
+begin
+  Selected := Assigned(ListViewTestCases.Selected);
+  ARun.Enabled := Selected;
+  AShow.Enabled := Selected;
 end;