Changeset 973 for trunk/Modules/NetworkConfigRouterOS

Timestamp:

Jun 30, 2025, 11:22:35 AM (4 weeks ago)

Author:

chronos

Message:

• Fixed: RouterOS doesn't always have wireless package to get wireless clients signal levels.

Location:

trunk/Modules/NetworkConfigRouterOS/Generators

Files:

• DHCP.php (modified) (2 diffs)
• FirewallFilter.php (modified) (2 diffs)
• Signal.php (modified) (3 diffs)

trunk/Modules/NetworkConfigRouterOS/Generators/DHCP.php

@@ -1 +1 @@
 <?php
-
 
 class ConfigRouterOSDHCP extends NetworkConfigItem
@@ -36 +35 @@
   }
 }
-

trunk/Modules/NetworkConfigRouterOS/Generators/FirewallFilter.php

@@ -7 +7 @@
     $Path = array('ip', 'firewall', 'filter');
 
-    $Routerboard = new Routerboard($this->SystemConfig['MainRouter']['HostName']);
-    $Routerboard->UserName = $this->SystemConfig['MainRouter']['UserName'];
-    $Routerboard->Timeout = $this->SystemConfig['MainRouter']['ConnectTimeout'];
+    $Routerboard = new Routerboard($this->System->Config['MainRouter']['HostName']);
+    $Routerboard->UserName = $this->System->Config['MainRouter']['UserName'];
+    $Routerboard->Timeout = $this->System->Config['MainRouter']['ConnectTimeout'];
     $Routerboard->Debug = true;
 
-    $InetInterface = $this->SystemConfig['MainRouter']['InetInterface'];
-    $LocalInterface = $this->SystemConfig['MainRouter']['LocalInterface'];
+    $InetInterface = $this->System->Config['MainRouter']['InetInterface'];
+    $LocalInterface = $this->System->Config['MainRouter']['LocalInterface'];
 
     $Items = array();
-
 
     // Total inet traffic measuring
@@ -38 +37 @@
     $Items[] = array('chain' => 'forward', 'out-interface' => $InetInterface, 'protocol' => 'tcp', 'dst-port' => 25, 'dst-address' => '82.119.226.113', 'action' => 'accept', 'comment' => 'smtp.svarko.cz');
     $Items[] = array('chain' => 'forward', 'out-interface' => $InetInterface, 'protocol' => 'tcp', 'dst-port' => 25, 'action' => 'drop', 'comment' => 'drop-rest-smtp');
-
 
     // Insert blocked addresses

trunk/Modules/NetworkConfigRouterOS/Generators/Signal.php

@@ -39 +39 @@
     $Read = $Routerboard->Read(false);
     $Array = $Routerboard->ParseResponse($Read);
+    if (array_key_exists('!trap', $Array))
+    {
+      return array();
+    }
     $NetworkMac = new NetworkMac($this->System);
     foreach ($Array as $Properties)
@@ -79 +83 @@
       $Queries[] = 'INSERT INTO `NetworkSignal` (`MAC`, `Value`, `Remote`, `RateRx`, `RateTx`, `Time`, `Interface`, `Device`) VALUES '.
         '('.$MacRef.', '.$Strength.', '.$RemoteSignal.', '.$RateRx.', '.$RateTx.', "'.
-        TimeToMysqlDateTime($this->Time).'", '.$Interface.', '.$Device['Id'].')';              
+        TimeToMysqlDateTime($this->Time).'", '.$Interface.', '.$Device['Id'].')';
     }
     return $Queries;
@@ -98 +102 @@
     {
       return array();
-    }    
+    }
     $NetworkMac = new NetworkMac($this->System);
     foreach ($Array as $Properties)