Changeset 525 for GraphicTest

Timestamp:

Apr 17, 2019, 4:48:42 PM (6 years ago)

Author:

chronos

Message:

• Fixed: Memory leaks in LazIntfImage copy method.

File:

• GraphicTest/Methods/ULazIntfImageColorsCopy.pas (modified) (5 diffs)

GraphicTest/Methods/ULazIntfImageColorsCopy.pas

@@ -13 +13 @@
 
   TLazIntfImageColorsCopy = class(TDrawMethodImage)
-    TempIntfImage: TLazIntfImage;
     constructor Create; override;
     destructor Destroy; override;
@@ -28 +27 @@
   inherited;
   Caption := 'TLazIntfImage.Colors copy';
-  TempIntfImage := TLazIntfImage.Create(0, 0);
   Description.Add('Method use TLazIntfImage class for faster access to bitmap pixels compared to simple access using TBitmap.Pixels.');
   Description.Add('TLazIntfImage is created from visible image.');
@@ -35 +33 @@
 destructor TLazIntfImageColorsCopy.Destroy;
 begin
-  TempIntfImage.Free;
   inherited Destroy;
 end;
@@ -42 +39 @@
 var
   Y, X: Integer;
+  TempIntfImage: TLazIntfImage;
 begin
   with FastBitmap do begin
+    TempIntfImage := TLazIntfImage.Create(Image.Picture.Bitmap.Width, Image.Picture.Bitmap.Height);
     TempIntfImage.LoadFromBitmap(Image.Picture.Bitmap.Handle,
       Image.Picture.Bitmap.MaskHandle);
@@ -50 +49 @@
         TempIntfImage.Colors[X, Y] := TColorToFPColor(SwapBRComponent(Pixels[X, Y]));
     Image.Picture.Bitmap.LoadFromIntfImage(TempIntfImage);
+    TempIntfImage.Free;
   end;
 end;