Changeset 129 for trunk/Packages/Common

Timestamp:

Jan 17, 2022, 10:11:05 PM (3 years ago)

Author:

chronos

Message:

• Modified: Eliminated compilation hints from Common package.

Location:

trunk/Packages/Common

Files:

• Common.lpk (modified) (3 diffs)
• UAboutDialog.pas (modified) (1 diff)
• UCommon.pas (modified) (5 diffs)
• UFindFile.pas (modified) (1 diff)
• UGeometric.pas (modified) (1 diff)
• UMetaCanvas.pas (modified) (3 diffs)
• URegistry.pas (modified) (2 diffs)
• UScaleDPI.pas (modified) (7 diffs)

trunk/Packages/Common/Common.lpk

@@ -1 +1 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <CONFIG>
-  <Package Version="4">
+  <Package Version="5">
     <PathDelim Value="\"/>
     <Name Value="Common"/>
@@ -33 +33 @@
       <Other>
         <CompilerMessages>
-          <IgnoredMessages idx5024="True"/>
+          <IgnoredMessages idx6058="True" idx5024="True" idx3124="True" idx3123="True"/>
         </CompilerMessages>
       </Other>
@@ -172 +172 @@
       </Item29>
     </Files>
+    <CompatibilityMode Value="True"/>
     <i18n>
       <EnableI18N Value="True"/>

trunk/Packages/Common/UAboutDialog.pas

@@ -7 +7 @@
 uses
   Classes, SysUtils, FileUtil, Forms, Controls, Graphics, Dialogs, Menus,
-  StdCtrls, ExtCtrls, UApplicationInfo, UCommon, UTranslator, UTheme, UFormAbout;
+  ExtCtrls, UApplicationInfo, UCommon, UTranslator, UTheme, UFormAbout;
 
 type

trunk/Packages/Common/UCommon.pas

@@ -6 +6 @@
 
 uses
-  {$ifdef Windows}Windows,{$endif}
-  {$ifdef Linux}baseunix,{$endif}
+  {$IFDEF WINDOWS}Windows,{$ENDIF}
+  {$IFDEF UNIX}baseunix,{$ENDIF}
   Classes, SysUtils, StrUtils, Dialogs, Process, LCLIntf,
   FileUtil; //, ShFolder, ShellAPI;
@@ -35 +35 @@
   DLLHandle1: HModule;
 
-{$IFDEF Windows}
+{$IFDEF WINDOWS}
   GetUserNameEx: procedure (NameFormat: DWORD;
     lpNameBuffer: LPSTR; nSize: PULONG); stdcall;
@@ -292 +292 @@
 function Explode(Separator: char; Data: string): TArrayOfString;
 begin
+  Result := nil;
   SetLength(Result, 0);
   while Pos(Separator, Data) > 0 do begin
@@ -346 +347 @@
   Name: UtsName;
 begin
+  Name := Default(UtsName);
   fpuname(Name);
   Result := Name.Nodename;
@@ -505 +507 @@
   I: Integer;
 begin
+  Result := Default(TArrayOfString);
   SetLength(Result, Length(A) + Length(B));
   for I := 0 to Length(A) - 1 do

trunk/Packages/Common/UFindFile.pas

@@ -59 +59 @@
   FilterAll = '*.*';
 {$ENDIF}
-{$IFDEF LINUX}
+{$IFDEF UNIX}
   FilterAll = '*';
 {$ENDIF}

trunk/Packages/Common/UGeometric.pas

@@ -96 +96 @@
   I: Integer;
 begin
+  Result := Default(TPointArray);
   SetLength(Result, Length(P));
   for I := 0 to High(P) do

trunk/Packages/Common/UMetaCanvas.pas

@@ -142 +142 @@
     procedure RoundRect(const Rect: TRect; RX,RY: Integer); overload;
     procedure TextOut(X,Y: Integer; const Text: String); override;
-    procedure Polygon(Points: PPoint; NumPts: Integer; Winding: boolean = False); override;
+    procedure Polygon(Points: PPoint; NumPts: Integer; Winding: Boolean = False); override;
     procedure Ellipse(x1, y1, x2, y2: Integer); override;
     procedure StretchDraw(const DestRect: TRect; SrcGraphic: TGraphic); override;
@@ -502 +502 @@
 end;
 
-procedure TMetaCanvas.Polygon(Points: PPoint; NumPts: Integer; Winding: boolean
+procedure TMetaCanvas.Polygon(Points: PPoint; NumPts: Integer; Winding: Boolean
   );
 var
@@ -508 +508 @@
   I: Integer;
 begin
+  APoints := nil;
   SetLength(APoints, NumPts);
   for I := 0 to High(APoints) do

trunk/Packages/Common/URegistry.pas

@@ -132 +132 @@
 function TRegistryEx.OpenKey(const Key: string; CanCreate: Boolean): Boolean;
 begin
-  {$IFDEF Linux}
+  {$IFDEF UNIX}
   //CloseKey;
   {$ENDIF}
@@ -140 +140 @@
 function TRegistryEx.GetCurrentContext: TRegistryContext;
 begin
-  Result.Key := CurrentPath;
+  Result.Key := String(CurrentPath);
   Result.RootKey := RootKey;
 end;

trunk/Packages/Common/UScaleDPI.pas

@@ -8 +8 @@
 
 uses
-  Classes, Forms, Graphics, Controls, ComCtrls, LCLType, SysUtils, StdCtrls,
-  Contnrs;
+  Classes, Forms, Graphics, Controls, ComCtrls, LCLType, SysUtils, fgl;
 
 type
+  TControlDimensions = class;
 
   { TControlDimension }
@@ -18 +18 @@
     BoundsRect: TRect;
     FontHeight: Integer;
-    Controls: TObjectList; // TList<TControlDimension>
+    Controls: TControlDimensions;
     // Class specifics
     ButtonSize: TPoint; // TToolBar
@@ -26 +26 @@
     constructor Create;
     destructor Destroy; override;
+  end;
+
+  TControlDimensions = class(TFPGObjectList<TControlDimension>)
   end;
 
@@ -73 +76 @@
 constructor TControlDimension.Create;
 begin
-  Controls := TObjectList.Create;
+  Controls := TControlDimensions.Create;
 end;
 
@@ -79 +82 @@
 begin
   FreeAndNil(Controls);
-  inherited Destroy;
+  inherited;
 end;
 
@@ -212 +215 @@
   TempBmp: TBitmap;
   Temp: array of TBitmap;
-  NewWidth, NewHeight: integer;
+  NewWidth: Integer;
+  NewHeight: Integer;
   I: Integer;
 begin
   ImgList.BeginUpdate;
-  NewWidth := ScaleX(ImgList.Width, FromDPI.X);
-  NewHeight := ScaleY(ImgList.Height, FromDPI.Y);
-
-  SetLength(Temp, ImgList.Count);
-  for I := 0 to ImgList.Count - 1 do
-  begin
-    TempBmp := TBitmap.Create;
-    TempBmp.PixelFormat := pf32bit;
-    ImgList.GetBitmap(I, TempBmp);
-    Temp[I] := TBitmap.Create;
-    Temp[I].SetSize(NewWidth, NewHeight);
-    {$IFDEF Linux}
-    Temp[I].PixelFormat := pf24bit;
-    {$ELSE}
-    Temp[I].PixelFormat := pf32bit;
-    {$ENDIF}
-    Temp[I].TransparentColor := TempBmp.TransparentColor;
-    //Temp[I].TransparentMode := TempBmp.TransparentMode;
-    Temp[I].Transparent := True;
-    Temp[I].Canvas.Brush.Style := bsSolid;
-    Temp[I].Canvas.Brush.Color := Temp[I].TransparentColor;
-    Temp[I].Canvas.FillRect(0, 0, Temp[I].Width, Temp[I].Height);
-
-    if (Temp[I].Width = 0) or (Temp[I].Height = 0) then Continue;
-    Temp[I].Canvas.StretchDraw(Rect(0, 0, Temp[I].Width, Temp[I].Height), TempBmp);
-    TempBmp.Free;
-  end;
-
-  ImgList.Clear;
-  ImgList.Width := NewWidth;
-  ImgList.Height := NewHeight;
-
-  for I := 0 to High(Temp) do
-  begin
-    ImgList.Add(Temp[I], nil);
-    Temp[i].Free;
-  end;
-  ImgList.EndUpdate;
+  try
+    NewWidth := ScaleX(ImgList.Width, FromDPI.X);
+    NewHeight := ScaleY(ImgList.Height, FromDPI.Y);
+
+    Temp := nil;
+    SetLength(Temp, ImgList.Count);
+    for I := 0 to ImgList.Count - 1 do
+    begin
+      TempBmp := TBitmap.Create;
+      try
+        TempBmp.PixelFormat := pf32bit;
+        ImgList.GetBitmap(I, TempBmp);
+        Temp[I] := TBitmap.Create;
+        Temp[I].SetSize(NewWidth, NewHeight);
+        {$IFDEF UNIX}
+        Temp[I].PixelFormat := pf24bit;
+        {$ELSE}
+        Temp[I].PixelFormat := pf32bit;
+        {$ENDIF}
+        Temp[I].TransparentColor := TempBmp.TransparentColor;
+        //Temp[I].TransparentMode := TempBmp.TransparentMode;
+        Temp[I].Transparent := True;
+        Temp[I].Canvas.Brush.Style := bsSolid;
+        Temp[I].Canvas.Brush.Color := Temp[I].TransparentColor;
+        Temp[I].Canvas.FillRect(0, 0, Temp[I].Width, Temp[I].Height);
+
+        if (Temp[I].Width = 0) or (Temp[I].Height = 0) then Continue;
+        Temp[I].Canvas.StretchDraw(Rect(0, 0, Temp[I].Width, Temp[I].Height), TempBmp);
+      finally
+        TempBmp.Free;
+      end;
+    end;
+
+    ImgList.Clear;
+    ImgList.Width := NewWidth;
+    ImgList.Height := NewHeight;
+
+    for I := 0 to High(Temp) do
+    begin
+      ImgList.Add(Temp[I], nil);
+      Temp[i].Free;
+    end;
+  finally
+    ImgList.EndUpdate;
+  end;
 end;
 
@@ -331 +342 @@
   with TCoolBar(Control) do begin
     BeginUpdate;
-    for I := 0 to Bands.Count - 1 do
-      with Bands[I] do begin
-        MinWidth := ScaleX(MinWidth, FromDPI.X);
-        MinHeight := ScaleY(MinHeight, FromDPI.Y);
-        // Workaround to bad band width auto sizing
-        //Width := ScaleX(Width, FromDPI.X);
-        Width := ScaleX(Control.Width + 28, FromDPI.X);
-        //Control.Invalidate;
+    try
+      for I := 0 to Bands.Count - 1 do
+        with Bands[I] do begin
+          MinWidth := ScaleX(MinWidth, FromDPI.X);
+          MinHeight := ScaleY(MinHeight, FromDPI.Y);
+          // Workaround to bad band width auto sizing
+          //Width := ScaleX(Width, FromDPI.X);
+          Width := ScaleX(Control.Width + 28, FromDPI.X);
+          //Control.Invalidate;
+        end;
+      // Workaround for bad autosizing of coolbar
+      if AutoSize then begin
+        AutoSize := False;
+        Height := ScaleY(Height, FromDPI.Y);
+        AutoSize := True;
       end;
-    // Workaround for bad autosizing of coolbar
-    if AutoSize then begin
-      AutoSize := False;
-      Height := ScaleY(Height, FromDPI.Y);
-      AutoSize := True;
-    end;
-    EndUpdate;
+    finally
+      EndUpdate;
+    end;
   end;